Unverified Commit 71989e70 authored by Muhong Guo's avatar Muhong Guo Committed by GitHub

Restricts the protobuf version to <5.0.0 in setup.py (#413)

# Description

Restricts the protobuf version to <5.0.0 in setup.py and closes
https://github.com/NVIDIA-Omniverse/orbit/issues/412

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Screenshots

| Before | After |
| ------ | ----- |
|
![image](https://github.com/NVIDIA-Omniverse/orbit/assets/17403324/cc41ae19-a22c-472b-8ab8-aa21d2b0b55d)
|
![image](https://github.com/NVIDIA-Omniverse/orbit/assets/17403324/eabf360b-5205-4eb6-a6ca-9403a94ad6d5)
|


## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have run all the tests with `./orbit.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
parent 1928161b
...@@ -39,9 +39,9 @@ Guidelines for modifications: ...@@ -39,9 +39,9 @@ Guidelines for modifications:
* Chenyu Yang * Chenyu Yang
* Jia Lin Yuan * Jia Lin Yuan
* Jingzhou Liu * Jingzhou Liu
* Kourosh Darvish
* Lorenz Wellhausen * Lorenz Wellhausen
* Muhong Guo * Muhong Guo
* Kourosh Darvish
* Özhan Özen * Özhan Özen
* Qinxi Yu * Qinxi Yu
* René Zurbrügg * René Zurbrügg
......
...@@ -22,7 +22,9 @@ INSTALL_REQUIRES = [ ...@@ -22,7 +22,9 @@ INSTALL_REQUIRES = [
"numpy", "numpy",
"torch==2.0.1", "torch==2.0.1",
"torchvision>=0.14.1", # ensure compatibility with torch 1.13.1 "torchvision>=0.14.1", # ensure compatibility with torch 1.13.1
"protobuf>=3.20.2", # 5.26.0 introduced a breaking change, so we restricted it for now.
# See issue https://github.com/tensorflow/tensorboard/issues/6808 for details.
"protobuf >= 3.19.6, < 5.0.0",
# data collection # data collection
"h5py", "h5py",
# basic logger # basic logger
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment