Unverified Commit 71e3ed9a authored by Mayank Mittal's avatar Mayank Mittal Committed by GitHub

Fixes deprecation notice for using `pxr.Semantics` (#1129)

# Description

It seems that `pxr.Semantics` module is now deprecated. Instead the
`Semantics` module should be used directly. This MR makes changes to the
affected modules.

Verified for Isaac Sim 4.2.

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

---------
Signed-off-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
parent 4ce87f84
...@@ -46,6 +46,7 @@ known_third_party = [ ...@@ -46,6 +46,7 @@ known_third_party = [
"omni.kit.*", "omni.kit.*",
"warp", "warp",
"carb", "carb",
"Semantics",
] ]
# Imports from this repository # Imports from this repository
known_first_party = "omni.isaac.lab" known_first_party = "omni.isaac.lab"
......
[package] [package]
# Note: Semantic Versioning is used: https://semver.org/ # Note: Semantic Versioning is used: https://semver.org/
version = "0.24.16" version = "0.24.17"
# Description # Description
title = "Isaac Lab framework for Robot Learning" title = "Isaac Lab framework for Robot Learning"
......
Changelog Changelog
--------- ---------
0.24.17 (2024-10-04)
~~~~~~~~~~~~~~~~~~~~
Fixed
^^^^^
* Fixed the deprecation notice for using ``pxr.Semantics``. The corresponding modules use ``Semantics`` module
directly.
0.24.16 (2024-10-03) 0.24.16 (2024-10-03)
~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~
......
...@@ -17,7 +17,13 @@ import carb ...@@ -17,7 +17,13 @@ import carb
import omni.isaac.core.utils.stage as stage_utils import omni.isaac.core.utils.stage as stage_utils
import omni.kit.commands import omni.kit.commands
from omni.isaac.cloner import Cloner from omni.isaac.cloner import Cloner
from pxr import PhysxSchema, Sdf, Semantics, Usd, UsdGeom, UsdPhysics, UsdShade from pxr import PhysxSchema, Sdf, Usd, UsdGeom, UsdPhysics, UsdShade
# from Isaac Sim 4.2 onwards, pxr.Semantics is deprecated
try:
import Semantics
except ModuleNotFoundError:
from pxr import Semantics
from omni.isaac.lab.utils.string import to_camel_case from omni.isaac.lab.utils.string import to_camel_case
......
...@@ -9,7 +9,12 @@ from __future__ import annotations ...@@ -9,7 +9,12 @@ from __future__ import annotations
import torch import torch
import omni.usd import omni.usd
from pxr import Semantics
# from Isaac Sim 4.2 onwards, pxr.Semantics is deprecated
try:
import Semantics
except ModuleNotFoundError:
from pxr import Semantics
import omni.isaac.lab.sim as sim_utils import omni.isaac.lab.sim as sim_utils
from omni.isaac.lab.assets import Articulation, RigidObject from omni.isaac.lab.assets import Articulation, RigidObject
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment