Commit ae222ba1 authored by Leul Tesfaye's avatar Leul Tesfaye Committed by Mayank Mittal

Fixes `VERSION` file not found when launching Isaac Sim (#340)

The AppLauncher has a bug where it fails to fact the `app.folder` is
pointing to a directory higher than it should be. This leads to a file
not being found in the `_get_version` call from `omni.isaac.version`
module.

Updated app.folder to point to `"${exe-path}/"` instead of
`"${exe-path}/../"` in the following files:

- orbit/source/apps/orbit.python.headless.kit
- orbit/source/apps/orbit.python.headless.multicam.kit
- orbit/source/apps/orbit.python.kit

Fixes #339

- Bug fix (non-breaking change which fixes an issue)

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have run all the tests with `./orbit.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
parent 76044b6d
...@@ -15,8 +15,8 @@ keywords = ["experience", "app", "orbit", "python", "headless"] ...@@ -15,8 +15,8 @@ keywords = ["experience", "app", "orbit", "python", "headless"]
################# #################
[settings] [settings]
# Note: This path was adapted to be respective to the kit-exe file location # Note: This path was adapted to be respective to the kit-exe file location
app.versionFile = "${exe-path}/../VERSION" app.versionFile = "${exe-path}/VERSION"
app.folder = "${exe-path}/../" app.folder = "${exe-path}/"
app.name = "Isaac-Sim" app.name = "Isaac-Sim"
app.version = "2023.1.1" app.version = "2023.1.1"
......
...@@ -48,8 +48,8 @@ keywords = ["experience", "app", "orbit", "python", "camera", "minimal"] ...@@ -48,8 +48,8 @@ keywords = ["experience", "app", "orbit", "python", "camera", "minimal"]
# Basic Kit App # Basic Kit App
################################ ################################
# Note: This path was adapted to be respective to the kit-exe file location # Note: This path was adapted to be respective to the kit-exe file location
app.versionFile = "${exe-path}/../VERSION" app.versionFile = "${exe-path}/VERSION"
app.folder = "${exe-path}/../" app.folder = "${exe-path}/"
app.name = "Isaac-Sim" app.name = "Isaac-Sim"
app.version = "2023.1.1" app.version = "2023.1.1"
......
...@@ -15,8 +15,8 @@ keywords = ["experience", "app", "orbit", "python"] ...@@ -15,8 +15,8 @@ keywords = ["experience", "app", "orbit", "python"]
################# #################
[settings] [settings]
# Note: This path was adapted to be respective to the kit-exe file location # Note: This path was adapted to be respective to the kit-exe file location
app.versionFile = "${exe-path}/../VERSION" app.versionFile = "${exe-path}/VERSION"
app.folder = "${exe-path}/../" app.folder = "${exe-path}/"
app.name = "Isaac-Sim" app.name = "Isaac-Sim"
app.version = "2023.1.1" app.version = "2023.1.1"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment