Unverified Commit c91a125c authored by Kelly Guo's avatar Kelly Guo Committed by GitHub

Fixes missing visible attribute in spawn_ground_plane (#3304)

# Description

`GroundPlaneCfg` allows for specifying `visible` parameter, but this
would not being parsed in `spawn_ground_plane`, resulting in the
parameter being a no-op when specified. This change adds a fix to parse
the `visible` parameter from the cfg and sets the visibility attribute
for the ground plane cfg appropriately.

Fixes #3263 

<!-- As a practice, it is recommended to open an issue to have
discussions on the proposed pull request.
This makes it easier for the community to keep track of what is being
developed or added, and if a given feature
is demanded by more than one party. -->

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->
parent 0f00ca2b
......@@ -217,6 +217,10 @@ def spawn_ground_plane(
# create semantic type and data attributes
sem.CreateSemanticTypeAttr().Set(semantic_type)
sem.CreateSemanticDataAttr().Set(semantic_value)
# Apply visibility
prim_utils.set_prim_visibility(prim, cfg.visible)
# return the prim
return prim
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment