Unverified Commit e6012c96 authored by jsmith-bdai's avatar jsmith-bdai Committed by GitHub

Cleans up prints from unit test runner (#433)

# Description

When I updated `run_all_tests.sh` to be runnable from any dir (#406),
some debugging prints accidentally made it into the commit 😅
These make it quite hard to read the test output. This PR removes the
debugging `print()` calls and replaces a few others with `logging` calls
for consistency.

<!-- As a practice, it is recommended to open an issue to have
discussions on the proposed pull request.
This makes it easier for the community to keep track of what is being
developed or added, and if a given feature
is demanded by more than one party. -->

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have run all the tests with `./orbit.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->
parent 6443c5a5
......@@ -165,16 +165,13 @@ def test_all(
completed_process = subprocess.run(
["bash", orbit_shell_path, "-p", test_path], check=True, capture_output=True, timeout=timeout
)
print(f"Completed Process: {completed_process}")
print(f"stdout: {completed_process.stdout}")
print(f"stderr: {completed_process.stderr}")
except subprocess.TimeoutExpired as e:
print(f"Timeout occurred: {e}")
logging.error(f"Timeout occurred: {e}")
result = "TIMEDOUT"
stdout = e.stdout
stderr = e.stderr
except Exception as e:
print(f"Exception {e}!")
logging.error(f"Exception {e}!")
result = "FAILED"
stdout = e.stdout
stderr = e.stderr
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment