• Hunter Hansen's avatar
    Fixes repeated Docker container names (#481) · 0865cf6b
    Hunter Hansen authored
    # Description
    
    As of [docker compose
    2.24.7](https://docs.docker.com/compose/release-notes/#2247), using the
    same name between containers is disallowed even if the profiles that
    launch them are mutually exclusive.
    
    This PR alters `docker-compose.yaml` such that containers will now be
    appended with their image extension (orbit-base, orbit-ros2). I've also
    added `resolve_image_extension` to the logic in `./container.sh` in
    order to handle the image_extension arguments.
    
    Fixes Public[
    #325](https://github.com/NVIDIA-Omniverse/orbit/issues/325)
    
    ## Type of change
    
    - Bug fix (non-breaking change which fixes an issue)
    
    ## Checklist
    
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./orbit.sh --format`
    - [x] I have made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I have run all the tests with `./orbit.sh --test` and they pass
    - [ ] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    
    <!--
    As you go through the checklist above, you can mark something as done by
    putting an x character in it
    
    For example,
    - [x] I have done this task
    - [ ] I have not done this task
    -->
    
    ---------
    Signed-off-by: 's avatarHunter Hansen <50837800+hhansen-bdai@users.noreply.github.com>
    Co-authored-by: 's avatarJames Smith <142246516+jsmith-bdai@users.noreply.github.com>
    0865cf6b
docker.rst 14.1 KB