• Hunter Hansen's avatar
    Adapts isaac sim path in the container to point to its symlink (#482) · dfa74872
    Hunter Hansen authored
    # Description
    
    The experience files that we host in Orbit rely upon an expression
    `${exe-path}`, specifically to resolve the location of the `VERSION`.
    From our `orbit.python.headless.kit`:
    ```
    app.versionFile = "${exe-path}/../VERSION"
    app.folder = "${exe-path}/../"
    ```
    This resolves to the full path of the calling exe, which is the `kit`
    application in isaac-sim.
    
    Currently this is broken in the container because we set
    `ISAACSIM_PATH=/isaac-sim`, which is broken during the path operations
    done on it. This PR fixes that by making
    `ISAACSIM_PATH=/workspace/orbit/_isaac_sim` as well as mapping other
    aliases (`python`, `python3`) through this path.
    
    I have also added `not self._livestream` as a precondition of enabling
    the `orbit.python.headless.kit` experience file, because otherwise we do
    not render to livestream.
    
    I also added fixes for all the newly failing tests, except for
    `test_urdf_converter.py`. I will add a fix for that to this branch as
    soon as I have one.
    
    UPDATE:
    It appears that `test_urdf_converter.py` was broken at least as far back
    as commit `a30d764d`, which precedes the experience file commit. I will
    therefore merge this without fixing that test.
    
    Fixes [#339](https://github.com/NVIDIA-Omniverse/orbit/issues/339),
    [#338](https://github.com/NVIDIA-Omniverse/orbit/issues/338)
    
    ## Type of change
    
    - Bug fix (non-breaking change which fixes an issue)
    
    ## Checklist
    
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./orbit.sh --format`
    - [ ] I have made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [x] I have run all the tests with `./orbit.sh --test` and they pass
    (except `test_urdf_converter.py`)
    - [ ] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    
    ---------
    Signed-off-by: 's avatarHunter Hansen <50837800+hhansen-bdai@users.noreply.github.com>
    Co-authored-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
    dfa74872
Dockerfile.base 3.18 KB