• Kelly Guo's avatar
    Fixes contact threshold when activating contact sensor (#3498) · 7e8ebe67
    Kelly Guo authored
    # Description
    
    We were incorrectly passing in the activate contact sensor boolean as
    the threshold when setting up the contact sensor API, which caused the
    sensor threshold to always be 1 when the sensor is activated. The
    desired behavior should be defaulting to 0 threshold.
    
    
    ## Type of change
    
    - Bug fix (non-breaking change which fixes an issue)
    - Breaking change (existing functionality will not work without user
    modification)
    
    ## Checklist
    
    - [x] I have read and understood the [contribution
    guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./isaaclab.sh --format`
    - [x] I have made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [x] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    
    <!--
    As you go through the checklist above, you can mark something as done by
    putting an x character in it
    
    For example,
    - [x] I have done this task
    - [ ] I have not done this task
    -->
    
    ---------
    Signed-off-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
    Signed-off-by: 's avatarKelly Guo <kellyg@nvidia.com>
    Co-authored-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
    7e8ebe67
CHANGELOG.rst 154 KB