Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
K
KincoActuatorIsaacLab
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • kevin
  • KincoActuatorIsaacLab
  • Repository

Switch branch/tag
  • KincoActuatorIsaacLab
  • source
  • isaaclab
  • test
  • actuators
  • test_dc_motor.py
Find file
BlameHistoryPermalink
  • James Tigue's avatar
    Fixes DCMotor clipping for negative power and adds actuator tests (#2300) · 24a78b68
    James Tigue authored Jul 23, 2025
    # Description
    
    This PR adds tests for actuator initialization, configuration, and
    computation for Implicit, IdealPD, and DC motor actuators.
    
    This PR also updates the DCMotor model to clip based on a four quadrant
    DC motor model. This will fix improper clipping in the negative power
    regions (i.e. positive torque and negative velocity or negative torque
    and positive velocity).
    
    NOTE: This PR is dependant on the pytest migration in:
    [2034](https://github.com/isaac-sim/IsaacLab/pull/2034)
    This PR includes changes made in
    [2291](https://github.com/isaac-sim/IsaacLab/pull/2291) and would be an
    alternate candidate.
    
    Fixes [#2139](https://github.com/isaac-sim/IsaacLab/issues/2139)
    
    <!-- As a practice, it is recommended to open an issue to have
    discussions on the proposed pull request.
    This makes it easier for the community to keep track of what is being
    developed or added, and if a given feature
    is demanded by more than one party. -->
    
    ## Type of change
    
    <!-- As you go through the list, delete the ones that are not
    applicable. -->
    
    - Bug fix (non-breaking change which fixes an issue)
    - New feature (non-breaking change which adds functionality)
    
    ## Screenshots
    
    
    ![image](https://github.com/user-attachments/assets/c94f877e-b3a9-441a-ad2e-ec6124cc64de)
    
    ## Checklist
    
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./isaaclab.sh --format`
    - [x] I have made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [x] I have added tests that prove my fix is effective or that my
    feature works
    - [x] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    
    <!--
    As you go through the checklist above, you can mark something as done by
    putting an x character in it
    
    For example,
    - [x] I have done this task
    - [ ] I have not done this task
    -->
    
    ---------
    Signed-off-by: 's avatarKelly Guo <kellyg@nvidia.com>
    Signed-off-by: 's avatarJames Tigue <166445701+jtigue-bdai@users.noreply.github.com>
    Signed-off-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
    Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
    Co-authored-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
    24a78b68
test_dc_motor.py 6.58 KB
EditWeb IDE

Replace test_dc_motor.py

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.