Unverified Commit 02d79b9d authored by AlvinC's avatar AlvinC Committed by GitHub

Fixes carb subscription API for gamepad device (#2173)

# Description

Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # SE2/3 gamepad that calling wrong omniverse API,
[https://docs.omniverse.nvidia.com/dev-guide/latest/programmer_ref/input-devices/gamepad.html#unsubscribing-the-gamepad-event-handler](url)

## Type of change

- Bug fix (non-breaking change which fixes an issue)


## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->

---------
Signed-off-by: 's avatarAlvinC <alvincny529@gmail.com>
parent 8936a5ac
......@@ -77,6 +77,7 @@ Guidelines for modifications:
* Michael Noseworthy
* Muhong Guo
* Nicola Loi
* Nuoyan Chen (Alvin)
* Nuralem Abizov
* Ori Gadot
* Oyindamola Omotuyi
......
......@@ -87,7 +87,7 @@ class Se2Gamepad(DeviceBase):
def __del__(self):
"""Unsubscribe from gamepad events."""
self._input.unsubscribe_from_gamepad_events(self._gamepad, self._gamepad_sub)
self._input.unsubscribe_to_gamepad_events(self._gamepad, self._gamepad_sub)
self._gamepad_sub = None
def __str__(self) -> str:
......
......@@ -88,7 +88,7 @@ class Se3Gamepad(DeviceBase):
def __del__(self):
"""Unsubscribe from gamepad events."""
self._input.unsubscribe_from_gamepad_events(self._gamepad, self._gamepad_sub)
self._input.unsubscribe_to_gamepad_events(self._gamepad, self._gamepad_sub)
self._gamepad_sub = None
def __str__(self) -> str:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment