Unverified Commit 62d1de92 authored by Kelly Guo's avatar Kelly Guo Committed by GitHub

Disables extension auto-reload when saving files (#1788)

# Description

Since extensions are now added to the app files, they get automatically
reloaded when changes happen in the extension scripts. This feature is
most likely not useful for Isaac Lab development workflows. This change
disables the hot reload feature as it causes confusion and unnecessary
reloading of the modules.

Fixes #1779 

<!-- As a practice, it is recommended to open an issue to have
discussions on the proposed pull request.
This makes it easier for the community to keep track of what is being
developed or added, and if a given feature
is demanded by more than one party. -->

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->
Co-authored-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
parent c4bec8fe
...@@ -32,5 +32,8 @@ modules = [ ...@@ -32,5 +32,8 @@ modules = [
use_online_index=true use_online_index=true
[core]
reloadable = false
[[python.module]] [[python.module]]
name = "isaaclab" name = "isaaclab"
...@@ -13,6 +13,9 @@ keywords = ["kit", "robotics", "assets", "isaaclab"] ...@@ -13,6 +13,9 @@ keywords = ["kit", "robotics", "assets", "isaaclab"]
[dependencies] [dependencies]
"isaaclab" = {} "isaaclab" = {}
[core]
reloadable = false
# Main python module this extension provides. # Main python module this extension provides.
[[python.module]] [[python.module]]
name = "isaaclab_assets" name = "isaaclab_assets"
...@@ -20,6 +20,9 @@ keywords = ["extension", "template", "isaaclab"] ...@@ -20,6 +20,9 @@ keywords = ["extension", "template", "isaaclab"]
"isaaclab_tasks" = {} "isaaclab_tasks" = {}
# NOTE: Add additional dependencies here # NOTE: Add additional dependencies here
[core]
reloadable = false
[[python.module]] [[python.module]]
name = "isaaclab_mimic" name = "isaaclab_mimic"
......
...@@ -16,5 +16,8 @@ keywords = ["robotics", "rl", "wrappers", "learning"] ...@@ -16,5 +16,8 @@ keywords = ["robotics", "rl", "wrappers", "learning"]
"isaaclab_assets" = {} "isaaclab_assets" = {}
"isaaclab_tasks" = {} "isaaclab_tasks" = {}
[core]
reloadable = false
[[python.module]] [[python.module]]
name = "isaaclab_rl" name = "isaaclab_rl"
...@@ -15,5 +15,8 @@ keywords = ["robotics", "rl", "il", "learning"] ...@@ -15,5 +15,8 @@ keywords = ["robotics", "rl", "il", "learning"]
"isaaclab" = {} "isaaclab" = {}
"isaaclab_assets" = {} "isaaclab_assets" = {}
[core]
reloadable = false
[[python.module]] [[python.module]]
name = "isaaclab_tasks" name = "isaaclab_tasks"
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment