Unverified Commit 8c5b4680 authored by Alexander Poddubny's avatar Alexander Poddubny Committed by GitHub

Fixes minor issues in CI (#3120)

# Description

1. Changed test reporter for compatibility pipeline to generate HTML
report
2. Increased the number of reported logs for failed test cases to 50
(max)
3. Set execute permissions in the Dockerfile on the isaaclab.sh -
sometimes the post-merge pipeline fails due to permissions
4. Updated the default Isaac SIM version
parent a4549680
...@@ -25,7 +25,7 @@ permissions: ...@@ -25,7 +25,7 @@ permissions:
env: env:
NGC_API_KEY: ${{ secrets.NGC_API_KEY }} NGC_API_KEY: ${{ secrets.NGC_API_KEY }}
ISAACSIM_BASE_IMAGE: ${{ vars.ISAACSIM_BASE_IMAGE || 'nvcr.io/nvidia/isaac-sim' }} ISAACSIM_BASE_IMAGE: ${{ vars.ISAACSIM_BASE_IMAGE || 'nvcr.io/nvidia/isaac-sim' }}
ISAACSIM_BASE_VERSION: ${{ vars.ISAACSIM_BASE_VERSION || '4.5.0' }} ISAACSIM_BASE_VERSION: ${{ vars.ISAACSIM_BASE_VERSION || '5.0.0' }}
DOCKER_IMAGE_TAG: isaac-lab-dev:${{ github.event_name == 'pull_request' && format('pr-{0}', github.event.pull_request.number) || github.ref_name }}-${{ github.sha }} DOCKER_IMAGE_TAG: isaac-lab-dev:${{ github.event_name == 'pull_request' && format('pr-{0}', github.event.pull_request.number) || github.ref_name }}-${{ github.sha }}
jobs: jobs:
...@@ -186,4 +186,5 @@ jobs: ...@@ -186,4 +186,5 @@ jobs:
reporter: java-junit reporter: java-junit
fail-on-error: true fail-on-error: true
only-summary: false only-summary: false
max-annotations: '50'
report-title: "IsaacLab Test Results - ${{ github.workflow }}" report-title: "IsaacLab Test Results - ${{ github.workflow }}"
...@@ -181,11 +181,15 @@ jobs: ...@@ -181,11 +181,15 @@ jobs:
retention-days: 30 retention-days: 30
compression-level: 9 compression-level: 9
- name: Publish Test Results - name: Report Test Results
uses: EnricoMi/publish-unit-test-result-action@v2 uses: dorny/test-reporter@v1
if: always() if: always()
with: with:
files: "reports/combined-compat-results.xml" name: IsaacLab Compatibility Test Results
path: reports/combined-compat-results.xml
reporter: java-junit
max-annotations: '50'
report-title: "IsaacLab Compatibility Test Results - ${{ github.workflow }}"
notify-compatibility-status: notify-compatibility-status:
needs: [combine-compat-results] needs: [combine-compat-results]
......
...@@ -22,7 +22,7 @@ permissions: ...@@ -22,7 +22,7 @@ permissions:
env: env:
NGC_API_KEY: ${{ secrets.NGC_API_KEY }} NGC_API_KEY: ${{ secrets.NGC_API_KEY }}
ISAACSIM_BASE_IMAGE: ${{ vars.ISAACSIM_BASE_IMAGE || 'nvcr.io/nvidia/isaac-sim' }} ISAACSIM_BASE_IMAGE: ${{ vars.ISAACSIM_BASE_IMAGE || 'nvcr.io/nvidia/isaac-sim' }}
ISAACSIM_BASE_VERSIONS_STRING: ${{ vars.ISAACSIM_BASE_VERSIONS_STRING || 'latest-base-4.5' }} ISAACSIM_BASE_VERSIONS_STRING: ${{ vars.ISAACSIM_BASE_VERSIONS_STRING || 'latest-base-5.0' }}
ISAACLAB_IMAGE_NAME: ${{ vars.ISAACLAB_IMAGE_NAME || 'isaac-lab-base' }} ISAACLAB_IMAGE_NAME: ${{ vars.ISAACLAB_IMAGE_NAME || 'isaac-lab-base' }}
jobs: jobs:
......
...@@ -51,6 +51,9 @@ RUN --mount=type=cache,target=/var/cache/apt \ ...@@ -51,6 +51,9 @@ RUN --mount=type=cache,target=/var/cache/apt \
# Copy the Isaac Lab directory (files to exclude are defined in .dockerignore) # Copy the Isaac Lab directory (files to exclude are defined in .dockerignore)
COPY ../ ${ISAACLAB_PATH} COPY ../ ${ISAACLAB_PATH}
# Ensure isaaclab.sh has execute permissions
RUN chmod +x ${ISAACLAB_PATH}/isaaclab.sh
# Set up a symbolic link between the installed Isaac Sim root folder and _isaac_sim in the Isaac Lab directory # Set up a symbolic link between the installed Isaac Sim root folder and _isaac_sim in the Isaac Lab directory
RUN ln -sf ${ISAACSIM_ROOT_PATH} ${ISAACLAB_PATH}/_isaac_sim RUN ln -sf ${ISAACSIM_ROOT_PATH} ${ISAACLAB_PATH}/_isaac_sim
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment