Commit 91165757 authored by Kelly Guo's avatar Kelly Guo Committed by Kelly Guo

Fixes modules being loaded when defined in extension.toml file (#237)

# Description

In the extension.toml for the isaaclab_rl and isaaclab_tasks extensions,
pipapi and module tags are specified for the various RL libraries. These
tags introduce an import call that loads these packages.

The SKRL package in particular will initialize torch.distributed if
running distributed training, causing errors if other RL libraries are
being used, since other libraries will try to initialize
torch.distributed again in its own code.

This should ideally be fixed from the SKRL side.


## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)


## Screenshots

Please attach before and after screenshots of the change if applicable.

<!--
Example:

| Before | After |
| ------ | ----- |
| _gif/png before_ | _gif/png after_ |

To upload images to a PR -- simply drag and drop an image while in edit
mode and it should upload the image directly. You can then paste that
source into the above before/after sections.
-->

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->
parent 944245a2
......@@ -16,26 +16,5 @@ keywords = ["robotics", "rl", "wrappers", "learning"]
"isaaclab_assets" = {}
"isaaclab_tasks" = {}
[python.pipapi]
requirements = [
"h5py",
"tensorboard",
"stable-baselines3>=2.1",
"rl-games==1.6.1",
"rsl-rl@git+https://github.com/leggedrobotics/rsl_rl.git",
"skrl>=1.3.0"
]
modules = [
"h5py",
"tensorboard",
"stable_baselines3",
"rl_games",
"rsl_rl",
"skrl"
]
use_online_index=true
[[python.module]]
name = "isaaclab_rl"
......@@ -15,26 +15,5 @@ keywords = ["robotics", "rl", "il", "learning"]
"isaaclab" = {}
"isaaclab_assets" = {}
[python.pipapi]
requirements = [
"h5py",
"tensorboard",
"stable-baselines3>=2.1",
"rl-games==1.6.1",
"rsl-rl@git+https://github.com/leggedrobotics/rsl_rl.git",
"skrl>=1.3.0"
]
modules = [
"h5py",
"tensorboard",
"stable_baselines3",
"rl_games",
"rsl_rl",
"skrl"
]
use_online_index=true
[[python.module]]
name = "isaaclab_tasks"
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment