Commit 9f137473 authored by rwiltz's avatar rwiltz Committed by Kelly Guo

Fixes the wrist rotation option in se3_abs_retargeter (#369)

# Description

Fixes the wrist rotation option in se3_abs_retargeter 

<!-- As a practice, it is recommended to open an issue to have
discussions on the proposed pull request.
This makes it easier for the community to keep track of what is being
developed or added, and if a given feature
is demanded by more than one party. -->

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)

## Screenshots

Please attach before and after screenshots of the change if applicable.

<!--
Example:

| Before | After |
| ------ | ----- |
| _gif/png before_ | _gif/png after_ |

To upload images to a PR -- simply drag and drop an image while in edit
mode and it should upload the image directly. You can then paste that
source into the above before/after sections.
-->

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->
parent bf80ade3
...@@ -109,7 +109,7 @@ class Se3AbsRetargeter(RetargeterBase): ...@@ -109,7 +109,7 @@ class Se3AbsRetargeter(RetargeterBase):
# Get rotation # Get rotation
if self._use_wrist_rotation: if self._use_wrist_rotation:
# wrist is w,x,y,z but scipy expects x,y,z,w # wrist is w,x,y,z but scipy expects x,y,z,w
base_rot = Rotation.from_quat([wrist[4:], wrist[3]]) base_rot = Rotation.from_quat([*wrist[4:], wrist[3]])
else: else:
# Average the orientations of thumb and index using SLERP # Average the orientations of thumb and index using SLERP
# thumb_tip is w,x,y,z but scipy expects x,y,z,w # thumb_tip is w,x,y,z but scipy expects x,y,z,w
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment