Commit a38c7e45 authored by rwiltz's avatar rwiltz Committed by Kelly Guo

Updates cli args if conditional defaults are enforced by app launcher (#324)

Update cli args if conditional defaults are enforced by app launcher

<!-- As a practice, it is recommended to open an issue to have
discussions on the proposed pull request.
This makes it easier for the community to keep track of what is being
developed or added, and if a given feature
is demanded by more than one party. -->

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- This change requires a documentation update

Please attach before and after screenshots of the change if applicable.

<!--
Example:

| Before | After |
| ------ | ----- |
| _gif/png before_ | _gif/png after_ |

To upload images to a PR -- simply drag and drop an image while in edit
mode and it should upload the image directly. You can then paste that
source into the above before/after sections.
-->

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->
parent e6cf93ef
[package]
# Note: Semantic Versioning is used: https://semver.org/
version = "0.36.13"
version = "0.36.14"
# Description
title = "Isaac Lab framework for Robot Learning"
......
Changelog
---------
0.36.13 (2025-04-09)
0.36.14 (2025-04-09)
~~~~~~~~~~~~~~~~~~~~
Changed
......@@ -12,7 +12,7 @@ Changed
the cuda device, which results in NCCL errors on distributed setups.
0.36.12 (2025-04-01)
0.36.13 (2025-04-01)
~~~~~~~~~~~~~~~~~~~~
Fixed
......@@ -21,7 +21,7 @@ Fixed
* Added check in RecorderManager to ensure that the success indicator is only set if the termination manager is present.
0.36.11 (2025-03-24)
0.36.12 (2025-03-24)
~~~~~~~~~~~~~~~~~~~~
Changed
......@@ -31,7 +31,7 @@ Changed
the default settings will be used from the experience files and the double definition is removed.
0.36.10 (2025-03-17)
0.36.11 (2025-03-19)
~~~~~~~~~~~~~~~~~~~~
Fixed
......@@ -41,6 +41,15 @@ Fixed
:attr:`effort_limit` is set.
0.36.10 (2025-03-17)
~~~~~~~~~~~~~~~~~~~~
Fixed
^^^^^
* App launcher to update the cli arguments if conditional defaults are used.
0.36.9 (2025-03-18)
~~~~~~~~~~~~~~~~~~~
......
......@@ -624,6 +624,9 @@ class AppLauncher:
# If no device is specified, default to the CPU device if we are running in XR
device = "cpu"
# Overwrite for downstream consumers
launcher_args["device"] = "cpu"
if "cuda" not in device and "cpu" not in device:
raise ValueError(
f"Invalid value for input keyword argument `device`: {device}."
......@@ -854,6 +857,9 @@ class AppLauncher:
# If no rendering mode is specified, default to the xr mode if we are running in XR
rendering_mode = "xr"
# Overwrite for downstream consumers
launcher_args["rendering_mode"] = "xr"
# parse preset file
repo_path = os.path.join(carb.tokens.get_tokens_interface().resolve("${app}"), "..")
preset_filename = os.path.join(repo_path, f"apps/rendering_modes/{rendering_mode}.kit")
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment