Unverified Commit b9ad4486 authored by peterd-NV's avatar peterd-NV Committed by GitHub

Removes custom sim params from Isaac-Stack-Cube-Franka-IK-Rel-v0 (#1853)

# Description

<!--
Thank you for your interest in sending a pull request. Please make sure
to check the contribution guidelines.

Link:
https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html
-->

This change removes the custom sim parameters used for the
`Isaac-Stack-Cube-Franka-IK-Rel-v0` env, setting it to use the same sim
parameters as the base environment config class and aligning it with the
other Franka stacking environments. This change increases simulation
stability and performance.

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Performance enhancement (non-breaking change which improves an
existing feature)

## Screenshots

Please attach before and after screenshots of the change if applicable.

<!--
Example:

| Before | After |
| ------ | ----- |
| _gif/png before_ | _gif/png after_ |

To upload images to a PR -- simply drag and drop an image while in edit
mode and it should upload the image directly. You can then paste that
source into the above before/after sections.
-->

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->
parent 077ae4da
[package]
# Note: Semantic Versioning is used: https://semver.org/
version = "0.10.23"
version = "0.10.24"
# Description
title = "Isaac Lab Environments"
......
Changelog
---------
0.10.24 (2025-02-13)
~~~~~~~~~~~~~~~~~~~~
Changed
^^^^^^^
* Set ``Isaac-Stack-Cube-Franka-IK-Rel-v0`` to use sim parameters from base ``StackEnvCfg``, improving simulation stability.
0.10.23 (2025-02-11)
~~~~~~~~~~~~~~~~~~~~
......
......@@ -34,10 +34,3 @@ class FrankaCubeStackEnvCfg(stack_joint_pos_env_cfg.FrankaCubeStackEnvCfg):
scale=0.5,
body_offset=DifferentialInverseKinematicsActionCfg.OffsetCfg(pos=[0.0, 0.0, 0.107]),
)
# Set the simulation parameters
self.sim.dt = 1 / 60
self.sim.render_interval = 1
self.decimation = 3
self.episode_length_s = 20.0
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment