Unverified Commit bc1d2a57 authored by Kelly Guo's avatar Kelly Guo Committed by GitHub

Updates render mode presets (#381)

# Description

Updates render mode presets to:

- better align balanced modes with current settings
- incorporate feedback from rendering team regarding use of
denoisingTechnique should always be 0 and avoid setting
upperLowerStrategy when RR is enabled

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)
- This change requires a documentation update

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->
parent dcd877f0
......@@ -3,7 +3,8 @@ rtx.translucency.enabled = false
rtx.reflections.enabled = false
rtx.reflections.denoiser.enabled = true
rtx.directLighting.sampledLighting.denoisingTechnique = 5
# this will be ignored when RR (dldenoiser) is enabled
# rtx.directLighting.sampledLighting.denoisingTechnique = 0
rtx.directLighting.sampledLighting.enabled = true
rtx.sceneDb.ambientLightIntensity = 1.0
......@@ -13,7 +14,7 @@ rtx.shadows.enabled = true
rtx.indirectDiffuse.enabled = false
rtx.indirectDiffuse.denoiser.enabled = true
rtx.domeLight.upperLowerStrategy = 3
# rtx.domeLight.upperLowerStrategy = 3
rtx.ambientOcclusion.enabled = false
rtx.ambientOcclusion.denoiserMode = 1
......@@ -23,10 +24,10 @@ rtx.raytracing.cached.enabled = true
# DLSS frame gen does not yet support tiled camera well
rtx-transient.dlssg.enabled = false
rtx-transient.dldenoiser.enabled = false
rtx-transient.dldenoiser.enabled = true
# Set the DLSS model
rtx.post.dlss.execMode = 2 # can be 0 (Performance), 1 (Balanced), 2 (Quality), or 3 (Auto)
rtx.post.dlss.execMode = 1 # can be 0 (Performance), 1 (Balanced), 2 (Quality), or 3 (Auto)
# Avoids replicator warning
rtx.pathtracing.maxSamplesPerLaunch = 1000000
......
......@@ -3,7 +3,7 @@ rtx.translucency.enabled = false
rtx.reflections.enabled = false
rtx.reflections.denoiser.enabled = false
rtx.directLighting.sampledLighting.denoisingTechnique = 5
rtx.directLighting.sampledLighting.denoisingTechnique = 0
rtx.directLighting.sampledLighting.enabled = false
rtx.sceneDb.ambientLightIntensity = 1.0
......@@ -26,7 +26,7 @@ rtx-transient.dlssg.enabled = false
rtx-transient.dldenoiser.enabled = false
# Set the DLSS model
rtx.post.dlss.execMode = 1 # can be 0 (Performance), 1 (Balanced), 2 (Quality), or 3 (Auto)
rtx.post.dlss.execMode = 0 # can be 0 (Performance), 1 (Balanced), 2 (Quality), or 3 (Auto)
# Avoids replicator warning
rtx.pathtracing.maxSamplesPerLaunch = 1000000
......
......@@ -3,7 +3,8 @@ rtx.translucency.enabled = true
rtx.reflections.enabled = true
rtx.reflections.denoiser.enabled = true
rtx.directLighting.sampledLighting.denoisingTechnique = 5
# this will be ignored when RR (dldenoiser) is enabled
# rtx.directLighting.sampledLighting.denoisingTechnique = 0
rtx.directLighting.sampledLighting.enabled = true
rtx.sceneDb.ambientLightIntensity = 1.0
......@@ -13,7 +14,7 @@ rtx.shadows.enabled = true
rtx.indirectDiffuse.enabled = true
rtx.indirectDiffuse.denoiser.enabled = true
rtx.domeLight.upperLowerStrategy = 4
# rtx.domeLight.upperLowerStrategy = 4
rtx.ambientOcclusion.enabled = true
rtx.ambientOcclusion.denoiserMode = 0
......
......@@ -70,8 +70,6 @@ def main():
# Now we are ready!
print("[INFO]: Setup complete...")
sim.play()
# Run simulation and view scene
while simulation_app.is_running():
sim.step()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment