Commit e17495bb authored by Kelly Guo's avatar Kelly Guo Committed by Kelly Guo

Fixes some tests and add new setting for time stepping (#451)

This change reverts some changes in the unit tests that were hacks
required in previous kit builds. Some of the issues have been fixed in
more recent versions.

We are now also setting `/app/player/useFixedTimeStepping=False` in
Isaac Lab as Isaac Sim used to do this by default, but is no longer
applying this setting in 5.0.

We are also dropping official support for Ubuntu 20.04 and adding
support for Ubuntu 24.04.

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- This change requires a documentation update

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->
parent 55b61988
...@@ -31,11 +31,11 @@ Describe the characteristic of your environment: ...@@ -31,11 +31,11 @@ Describe the characteristic of your environment:
<!-- Please complete the following description. --> <!-- Please complete the following description. -->
- Commit: [e.g. 8f3b9ca] - Commit: [e.g. 8f3b9ca]
- Isaac Sim Version: [e.g. 2022.2.0, this can be obtained by `cat ${ISAACSIM_PATH}/VERSION`] - Isaac Sim Version: [e.g. 5.0, this can be obtained by `cat ${ISAACSIM_PATH}/VERSION`]
- OS: [e.g. Ubuntu 20.04] - OS: [e.g. Ubuntu 22.04]
- GPU: [e.g. RTX 2060 Super] - GPU: [e.g. RTX 5090]
- CUDA: [e.g. 11.4] - CUDA: [e.g. 12.8]
- GPU Driver: [e.g. 470.82.01, this can be seen by using `nvidia-smi` command.] - GPU Driver: [e.g. 553.05, this can be seen by using `nvidia-smi` command.]
### Additional context ### Additional context
......
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
[![IsaacSim](https://img.shields.io/badge/IsaacSim-5.0.0-silver.svg)](https://docs.isaacsim.omniverse.nvidia.com/latest/index.html) [![IsaacSim](https://img.shields.io/badge/IsaacSim-5.0.0-silver.svg)](https://docs.isaacsim.omniverse.nvidia.com/latest/index.html)
[![Python](https://img.shields.io/badge/python-3.11-blue.svg)](https://docs.python.org/3/whatsnew/3.11.html) [![Python](https://img.shields.io/badge/python-3.11-blue.svg)](https://docs.python.org/3/whatsnew/3.11.html)
[![Linux platform](https://img.shields.io/badge/platform-linux--64-orange.svg)](https://releases.ubuntu.com/20.04/) [![Linux platform](https://img.shields.io/badge/platform-linux--64-orange.svg)](https://releases.ubuntu.com/22.04/)
[![Windows platform](https://img.shields.io/badge/platform-windows--64-orange.svg)](https://www.microsoft.com/en-us/) [![Windows platform](https://img.shields.io/badge/platform-windows--64-orange.svg)](https://www.microsoft.com/en-us/)
[![pre-commit](https://img.shields.io/github/actions/workflow/status/isaac-sim/IsaacLab/pre-commit.yaml?logo=pre-commit&logoColor=white&label=pre-commit&color=brightgreen)](https://github.com/isaac-sim/IsaacLab/actions/workflows/pre-commit.yaml) [![pre-commit](https://img.shields.io/github/actions/workflow/status/isaac-sim/IsaacLab/pre-commit.yaml?logo=pre-commit&logoColor=white&label=pre-commit&color=brightgreen)](https://github.com/isaac-sim/IsaacLab/actions/workflows/pre-commit.yaml)
[![docs status](https://img.shields.io/github/actions/workflow/status/isaac-sim/IsaacLab/docs.yaml?label=docs&color=brightgreen)](https://github.com/isaac-sim/IsaacLab/actions/workflows/docs.yaml) [![docs status](https://img.shields.io/github/actions/workflow/status/isaac-sim/IsaacLab/docs.yaml?label=docs&color=brightgreen)](https://github.com/isaac-sim/IsaacLab/actions/workflows/docs.yaml)
......
...@@ -30,9 +30,8 @@ app.version = "5.0.0" ...@@ -30,9 +30,8 @@ app.version = "5.0.0"
"omni.kit.loop" = {} "omni.kit.loop" = {}
# this is needed to create physics material through CreatePreviewSurfaceMaterialPrim # this is needed to create physics material through CreatePreviewSurfaceMaterialPrim
"omni.kit.usd.mdl" = {} "omni.kit.usd.mdl" = {}
# this is used for converting assets that have the wrong units
"omni.usd.metrics.assembler.ui" = {} "omni.usd.metrics.assembler.ui" = {}
# this is now needed in Kit 107.3 for CPU kinematics rigid body tests to pass
"omni.volume" = {}
[settings] [settings]
app.content.emptyStageOnStart = false app.content.emptyStageOnStart = false
......
...@@ -13,6 +13,10 @@ Breaking Changes ...@@ -13,6 +13,10 @@ Breaking Changes
* :attr:`~isaaclab.sim.spawners.PhysicsMaterialCfg.improve_patch_friction` is now removed. The simulation will always behave as if this attribute is set to true. * :attr:`~isaaclab.sim.spawners.PhysicsMaterialCfg.improve_patch_friction` is now removed. The simulation will always behave as if this attribute is set to true.
* Native Livestreaming support has been removed. ``LIVESTREAM=1`` can now be used for WebRTC streaming over public networks and * Native Livestreaming support has been removed. ``LIVESTREAM=1`` can now be used for WebRTC streaming over public networks and
``LIVESTREAM=2`` for private and local networks with WebRTC streaming. ``LIVESTREAM=2`` for private and local networks with WebRTC streaming.
* Python version has been updated to 3.11 from 3.10
* Official support for Ubuntu 20.04 has been dropped. We now officially support Ubuntu 22.04 and 24.04 Linux platforms.
* Isaac Sim 5.0 no longer sets ``/app/player/useFixedTimeStepping=False`` by default. We now do this in Isaac Lab.
v2.1.0 v2.1.0
====== ======
......
...@@ -50,8 +50,7 @@ The Isaac Lab pip packages only provide the core framework extensions for Isaac ...@@ -50,8 +50,7 @@ The Isaac Lab pip packages only provide the core framework extensions for Isaac
standalone training, inferencing, and example scripts. Therefore, this workflow is recommended for projects that are standalone training, inferencing, and example scripts. Therefore, this workflow is recommended for projects that are
built as external extensions outside of Isaac Lab, which utilizes user-defined runner scripts. built as external extensions outside of Isaac Lab, which utilizes user-defined runner scripts.
For Ubuntu 22.04 and Windows systems, we recommend using Isaac Sim pip installation. We recommend using Isaac Sim pip installation for a simplified installation experience.
For Ubuntu 20.04 systems, we recommend installing Isaac Sim through binaries.
For users getting started with Isaac Lab, we recommend installing Isaac Lab by cloning the repo. For users getting started with Isaac Lab, we recommend installing Isaac Lab by cloning the repo.
...@@ -59,7 +58,7 @@ For users getting started with Isaac Lab, we recommend installing Isaac Lab by c ...@@ -59,7 +58,7 @@ For users getting started with Isaac Lab, we recommend installing Isaac Lab by c
.. toctree:: .. toctree::
:maxdepth: 2 :maxdepth: 2
Pip installation (recommended for Ubuntu 22.04 and Windows) <pip_installation> Pip installation (recommended) <pip_installation>
Binary installation (recommended for Ubuntu 20.04) <binaries_installation> Binary installation <binaries_installation>
Advanced installation (Isaac Lab pip) <isaaclab_pip_installation> Advanced installation (Isaac Lab pip) <isaaclab_pip_installation>
Asset caching <asset_caching> Asset caching <asset_caching>
...@@ -27,13 +27,7 @@ Quick Installation Guide ...@@ -27,13 +27,7 @@ Quick Installation Guide
There are many ways to :ref:`install <isaaclab-installation-root>` Isaac Lab, but for the purposes of this quickstart guide, we will follow the There are many ways to :ref:`install <isaaclab-installation-root>` Isaac Lab, but for the purposes of this quickstart guide, we will follow the
pip install route using virtual environments. pip install route using virtual environments.
To begin, we first define our virtual environment.
.. note::
If you are using Ubuntu 20.04, you will need to follow the :ref:`Binary Installation Guide <isaaclab-binaries-installation>` instead of the pip install route described below.
To begin, we first define our virtual environment. We recommend using `miniconda <https://docs.conda.io/en/latest/miniconda.html>`_ to create a virtual environment.
.. code-block:: bash .. code-block:: bash
......
...@@ -293,7 +293,7 @@ print_help () { ...@@ -293,7 +293,7 @@ print_help () {
if [ -z "$*" ]; then if [ -z "$*" ]; then
echo "[Error] No arguments provided." >&2; echo "[Error] No arguments provided." >&2;
print_help print_help
exit 1 exit 0
fi fi
# pass the arguments # pass the arguments
......
...@@ -830,6 +830,10 @@ class AppLauncher: ...@@ -830,6 +830,10 @@ class AppLauncher:
# set fabric update flag to disable updating transforms when rendering is disabled # set fabric update flag to disable updating transforms when rendering is disabled
carb_settings_iface.set_bool("/physics/fabricUpdateTransformations", self._rendering_enabled()) carb_settings_iface.set_bool("/physics/fabricUpdateTransformations", self._rendering_enabled())
# in theory, this should ensure that dt is consistent across time stepping, but this is not the case
# for now, we use the custom loop runner from Isaac Sim to achieve this
carb_settings_iface.set_bool("/app/player/useFixedTimeStepping", False)
def _hide_stop_button(self): def _hide_stop_button(self):
"""Hide the stop button in the toolbar. """Hide the stop button in the toolbar.
......
...@@ -33,9 +33,7 @@ def setup_environment(): ...@@ -33,9 +33,7 @@ def setup_environment():
registered_tasks = list() registered_tasks = list()
for task_spec in gym.registry.values(): for task_spec in gym.registry.values():
if "Isaac" in task_spec.id and not task_spec.id.endswith("Play-v0") and "Factory" in task_spec.id: if "Isaac" in task_spec.id and not task_spec.id.endswith("Play-v0") and "Factory" in task_spec.id:
# TODO: We need to fix this environment!!! registered_tasks.append(task_spec.id)
if "Isaac-Factory-PegInsert-Direct-v0" not in task_spec.id:
registered_tasks.append(task_spec.id)
# sort environments by name # sort environments by name
registered_tasks.sort() registered_tasks.sort()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment