• Kris Wilson's avatar
    Removes protobuf upper version pin (#2726) · 05c22beb
    Kris Wilson authored
    # Description
    
    This PR relaxes the upper range of allowed protobuf versions so that
    IsaacLab can be installed in a modern python environment without
    downgrading or conflicting with modern protobuf versions.
    
    The original reason for pinning this to <5 was apparently due to
    transitive breakage in tensorboard, which also had this pinned to <5 -
    so pinning this in IsaacLab itself would not be necessary if both deps
    were composed together. Tensorboard has since (in Aug 2024) unpinned
    this here: https://github.com/tensorflow/tensorboard/pull/6888
    
    So, the original concern should, afaict, be obviated now.
    
    # Fixes
    
    This should repair any case where someone wants to install IsaacLab into
    a modern python environment that uses any of the Google ecosystem
    (gRPC/protobuf et al) without conflict or forced down-rev'ing to older
    versions (current version of protobuf is 6.31.1).
    
    ## Type of change
    
    - Bug fix (non-breaking change which fixes an issue)
    
    ## Checklist
    
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./isaaclab.sh --format`
    - [x] I have made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [x] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    05c22beb
Name
Last commit
Last update
.aws Loading commit data...
.github Loading commit data...
.vscode Loading commit data...
apps Loading commit data...
docker Loading commit data...
docs Loading commit data...
scripts Loading commit data...
source Loading commit data...
tools Loading commit data...
.dockerignore Loading commit data...
.flake8 Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.pre-commit-config.yaml Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS.md Loading commit data...
LICENSE Loading commit data...
LICENSE-mimic Loading commit data...
README.md Loading commit data...
SECURITY.md Loading commit data...
VERSION Loading commit data...
environment.yml Loading commit data...
isaaclab.bat Loading commit data...
isaaclab.sh Loading commit data...
pyproject.toml Loading commit data...