• Mayank Mittal's avatar
    Simplifies the Articulation initialization by adding some other hacks (#243) · 13327b8a
    Mayank Mittal authored
    # Description
    
    Earlier we were copying the whole `ArticulationView.initialize()` method
    from Isaac Sim since it doesn't work with our initialization callback
    hooks. Since this was bulking up the code and requires us to keep
    duplicating their function, this MR replaces the current fix with some
    tricks that work in a less bulky way.
    
    Additionally, the MR fixes the property name `default_root_state_w` to
    `default_root_state` since the latter is more correct (environment
    origin instead of world origin).
    
    ## Type of change
    
    - Bug fix (non-breaking change which fixes an issue)
    - Breaking change (fix or feature that would cause existing
    functionality to not work as expected)
    
    ## Checklist
    
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./orbit.sh --format`
    - [x] I have made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [x] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    13327b8a
Name
Last commit
Last update
.github Loading commit data...
.vscode Loading commit data...
docker Loading commit data...
docs Loading commit data...
source Loading commit data...
.dockerignore Loading commit data...
.flake8 Loading commit data...
.gitignore Loading commit data...
.pre-commit-config.yaml Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS.md Loading commit data...
LICENSE Loading commit data...
README.md Loading commit data...
VERSION Loading commit data...
orbit.sh Loading commit data...
pyproject.toml Loading commit data...