• Mayank Mittal's avatar
    Fixes a bug in terrain generation when `make_plane` is used (#53) · cab9c56c
    Mayank Mittal authored
    # Description
    
    <!--
    Thank you for your interest in sending a pull request. Please make sure
    to check the contribution guidelines.
    
    Link: https://isaac-orbit.github.io/orbit/source/refs/contributing.html
    -->
    
    Previously the `make_plane` function was always offsetting the terrain
    origin such that the origin of the plane coincides with (0, 0). This was
    done because when adding a ground plane, we wanted the origin to match
    the simulation origin. However, it introduced a bug in sub-terrain
    generator where we assume that all sub-terrains are origin at (size_x *
    0.5, size_y * 0.5).
    
    The PR fixes this issue by making an explicit argument to `make_plane`
    called `centered`. Also adds comments to make it clear what the
    sub-terrain generator and terrain importer does.
    
    <!-- As a practice, it is recommended to open an issue to have
    discussions on the proposed pull request.
    This makes it easier for the community to keep track of what is being
    developed or added, and if a given feature
    is demanded by more than one party. -->
    
    ## Type of change
    
    <!-- As you go through the list, delete the ones that are not
    applicable. -->
    
    - Bug fix (non-breaking change which fixes an issue)
    
    ## Screenshots
    
    | Before | After |
    | ------ | ----- |
    |
    ![bug](https://github.com/isaac-orbit/orbit/assets/12863862/1ce9db23-b97b-44d9-8a4e-1c543eab914b)|
    ![fix](https://github.com/isaac-orbit/orbit/assets/12863862/b347077b-daa6-4d76-a307-4e97450ccce9)
    |
    
    
    ## Checklist
    
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./orbit.sh --format`
    - [x] I have made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [x] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    
    <!--
    As you go through the checklist above, you can mark something as done by
    putting an x character in it
    
    For example,
    - [x] I have done this task
    - [ ] I have not done this task
    -->
    cab9c56c
Name
Last commit
Last update
..
omni.isaac.contrib_envs Loading commit data...
omni.isaac.orbit Loading commit data...
omni.isaac.orbit_envs Loading commit data...