• CY Chen's avatar
    Replaces is_success method with success termination term in mimic (#225) · d083ab36
    CY Chen authored
    # Description
    
    Update mimic to rely on an environment's "success" termination term to
    determine if an episode ends with success.
    As a result, is_success API in the mimic class `ManagerBasedRLMimicEnv`
    is no longer required and hence removed.
    
    ## Type of change
    
    <!-- As you go through the list, delete the ones that are not
    applicable. -->
    
    - Bug fix (non-breaking change which fixes an issue)
    
    ## Checklist
    
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./isaaclab.sh --format`
    - [x] I have made corresponding changes to the documentation
    - [ ] My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    
    <!--
    As you go through the checklist above, you can mark something as done by
    putting an x character in it
    
    For example,
    - [x] I have done this task
    - [ ] I have not done this task
    -->
    
    ---------
    Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
    d083ab36
Name
Last commit
Last update
..
config Loading commit data...
docs Loading commit data...
isaaclab_mimic Loading commit data...
test Loading commit data...
pyproject.toml Loading commit data...
setup.py Loading commit data...