• Manuel Schweiger's avatar
    Adds dict conversion test for ActuatorBase configs (#1608) · 9ab52d47
    Manuel Schweiger authored
    # Description
    
    <!--
    Thank you for your interest in sending a pull request. Please make sure
    to check the contribution guidelines.
    
    Link: https://isaac-sim.github.io/IsaacLab/source/refs/contributing.html
    -->
    
    A recent PR
    (https://github.com/isaac-sim/IsaacLab/pull/1530#issuecomment-2558120594)
    causes issues with joint_parameter_lookup attributes of Articulation
    Configs. The `class_to_dict` utility function needs to return a
    primitive dict. Returning a torch.Tensor conflicts with OmegaConf.
    
    This PR adds a unittest for the dict conversion as requested by @lgulich
    so that the issue can be fixed. The test case fails on main branch as
    expected according to my understanding. Passes on v1.3.0.
    
    <!-- As a practice, it is recommended to open an issue to have
    discussions on the proposed pull request.
    This makes it easier for the community to keep track of what is being
    developed or added, and if a given feature
    is demanded by more than one party. -->
    
    ## Type of change
    
    <!-- As you go through the list, delete the ones that are not
    applicable. -->
    
    - Breaking change (fix or feature that would cause existing
    functionality to not work as expected)
    
    <!--
    Example:
    
    | Before | After |
    | ------ | ----- |
    | _gif/png before_ | _gif/png after_ |
    
    To upload images to a PR -- simply drag and drop an image while in edit
    mode and it should upload the image directly. You can then paste that
    source into the above before/after sections.
    -->
    
    ## Checklist
    
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./isaaclab.sh --format`
    - [ ] I have made corresponding changes to the documentation
    - [ ] My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    
    <!--
    As you go through the checklist above, you can mark something as done by
    putting an x character in it
    
    For example,
    - [x] I have done this task
    - [ ] I have not done this task
    -->
    9ab52d47
Name
Last commit
Last update
..
test_assets.py Loading commit data...
test_circular_buffer.py Loading commit data...
test_configclass.py Loading commit data...
test_delay_buffer.py Loading commit data...
test_dict.py Loading commit data...
test_episode_data.py Loading commit data...
test_hdf5_dataset_file_handler.py Loading commit data...
test_math.py Loading commit data...
test_modifiers.py Loading commit data...
test_noise.py Loading commit data...
test_string.py Loading commit data...
test_timer.py Loading commit data...