• Mayank Mittal's avatar
    Fixes camera MDP term name and reprojection docstrings (#1130) · 4ce87f84
    Mayank Mittal authored
    # Description
    
    For all observation-related terms, we follow the noun name for the
    function. However, the camera one was called `grab_images`. This MR
    renames it to `image` to make it consistent with the others.
    
    Also the docstring for the math-utils were messed up. According to
    Google's docstyle, the first line should be a short summary and a
    detailed summary should move to the next paragraph. This MR fixes that
    as well.
    
    Lastly, the name of the function
    `convert_perspective_depth_to_orthoginal_depth` has too much redundancy.
    The MR renames it to `orthogonalize_perpsective_depth`.
    
    All these are breaking changes with no backwards compatibility (since
    they were added post-last release anyway).
    
    ## Type of change
    
    - Breaking change (fix or feature that would cause existing
    functionality to not work as expected)
    - This change requires a documentation update
    
    ## Checklist
    
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./isaaclab.sh --format`
    - [x] I have made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    
    ---------
    Signed-off-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
    4ce87f84
Name
Last commit
Last update
.github Loading commit data...
.vscode Loading commit data...
docker Loading commit data...
docs Loading commit data...
source Loading commit data...
tools Loading commit data...
.dockerignore Loading commit data...
.flake8 Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.pre-commit-config.yaml Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS.md Loading commit data...
LICENSE Loading commit data...
README.md Loading commit data...
VERSION Loading commit data...
isaaclab.bat Loading commit data...
isaaclab.sh Loading commit data...
pyproject.toml Loading commit data...