• ooctipus's avatar
    Fixes SB3's template ppo cfg up to date with security-safe syntax for training... · 6131a573
    ooctipus authored
    Fixes SB3's template ppo cfg up to date with security-safe syntax for training specification (#3688)
    
    # Description
    
    This PR fixes the bug where if template is generated using SB3, the code
    does not run because it couldn't parse from string
    ```
    policy_kwargs: "dict(
                      activation_fn=nn.ELU,
                      net_arch=[32, 32],
                      squash_output=False,
                    )"
    ```
    
    We have disabled the string parsing, as it is not safe(aka arbitrary
    code could be parsed)
    
    this PR makes sure the sb3's template also adopt the new secure syntax
    
    ```
    policy_kwargs:
      activation_fn: nn.ELU
      net_arch: [32, 32]
      squash_output: False
    ```
    
    ## Checklist
    
    - [x] I have read and understood the [contribution
    guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./isaaclab.sh --format`
    - [ ] I have made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    
    <!--
    As you go through the checklist above, you can mark something as done by
    putting an x character in it
    
    For example,
    - [x] I have done this task
    - [ ] I have not done this task
    -->
    6131a573
Name
Last commit
Last update
.github Loading commit data...
.vscode Loading commit data...
apps Loading commit data...
docker Loading commit data...
docs Loading commit data...
scripts Loading commit data...
source Loading commit data...
tools Loading commit data...
.dockerignore Loading commit data...
.flake8 Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.pre-commit-config.yaml Loading commit data...
CITATION.cff Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS.md Loading commit data...
LICENSE Loading commit data...
LICENSE-mimic Loading commit data...
README.md Loading commit data...
SECURITY.md Loading commit data...
VERSION Loading commit data...
environment.yml Loading commit data...
isaaclab.bat Loading commit data...
isaaclab.sh Loading commit data...
pyproject.toml Loading commit data...
pytest.ini Loading commit data...