• peterd-NV's avatar
    Adds parameter to specify number of rerenders after environment reset (#3818) · 64681ea9
    peterd-NV authored
    # Description
    
    <!--
    Thank you for your interest in sending a pull request. Please make sure
    to check the contribution guidelines.
    
    Link:
    https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html
    
    💡 Please try to keep PRs small and focused. Large PRs are harder to
    review and merge.
    -->
    
    Adds a new parameter to ManagerBasedEnv and DirectRLEnv to give users
    better control over rerender on reset behaviour. The new parameter
    `num_rerenders_on_reset` allows users to explicitly define the number of
    re-render steps after an env reset. When using DLSS, this allows for the
    elimination of artifacts/ghosting that are present after a single
    rendering step.
    
    Add a deprecation warning for the old parameter `rerender_on_reset`.
    Functionality of old parameter is preserved.
    
    Updates the existing visuomotor envs to use new rerendering API together
    with DLAA for high quality rendering.
    
    Fixes # (issue)
    
    Non-DLSS denoising is not supported on aarch64. There are also future
    plans from the rendering team to disable use of non-DLSS antialiasing
    for all platforms in the future. This causes an issue for visuomotor
    envs which suffer from image ghosting/artifacts when using DLSS. The new
    rerendering API allows for users of visuomotor envs to enable DLSS/DLAA
    while preserving image integrity.
    
    ## Type of change
    
    <!-- As you go through the list, delete the ones that are not
    applicable. -->
    
    - New feature (non-breaking change which adds functionality)
    
    ## Screenshots
    
    Please attach before and after screenshots of the change if applicable.
    
    <!--
    Example:
    
    | Before | After |
    | ------ | ----- |
    | _gif/png before_ | _gif/png after_ |
    
    To upload images to a PR -- simply drag and drop an image while in edit
    mode and it should upload the image directly. You can then paste that
    source into the above before/after sections.
    -->
    
    ## Checklist
    
    - [x] I have read and understood the [contribution
    guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./isaaclab.sh --format`
    - [ ] I have made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [x] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    
    <!--
    As you go through the checklist above, you can mark something as done by
    putting an x character in it
    
    For example,
    - [x] I have done this task
    - [ ] I have not done this task
    -->
    
    ---------
    Signed-off-by: 's avatarKelly Guo <kellyg@nvidia.com>
    Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
    64681ea9
Name
Last commit
Last update
..
isaaclab Loading commit data...
isaaclab_assets Loading commit data...
isaaclab_mimic Loading commit data...
isaaclab_rl Loading commit data...
isaaclab_tasks Loading commit data...