• Octi Zhang's avatar
    Computes Jacobian in the root frame inside the `DifferentialInverseKinematicsAction` class (#967) · 762f4e32
    Octi Zhang authored
    # Description
    
    This pull request fix the bug where jacobian returned by
    DifferentialInverseKinematicsAction._compute_fame_jacobian are not truly
    in robot base frame because it did not consider robot's base rotation.
    After the change, _compute_fame_jacobian returns the correct local frame
    jacobian. In addition, properties get_jacobian_w and get_jacobian_b is
    added to differentiate frame differences
    
    Fixes #911 
    
    ## Type of change
    - Bug fix (non-breaking change which fixes an issue)
    
    ## Screenshots
    
    <img width="1109" alt="image"
    src="https://github.com/user-attachments/assets/5d47dfb3-8c44-4115-b5a0-28c671e99459">
    
    ## Checklist
    
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./isaaclab.sh --format`
    - [ ] I have made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [x] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    
    <!--
    As you go through the checklist above, you can mark something as done by
    putting an x character in it
    
    For example,
    - [x] I have done this task
    - [ ] I have not done this task
    -->
    Signed-off-by: 's avatarOcti Zhang <127588710+zoctipus@users.noreply.github.com>
    Signed-off-by: 's avatarKelly Guo <kellyg@nvidia.com>
    Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
    762f4e32
Name
Last commit
Last update
..
app Loading commit data...
assets Loading commit data...
controllers Loading commit data...
deps Loading commit data...
devices Loading commit data...
envs Loading commit data...
managers Loading commit data...
markers Loading commit data...
performance Loading commit data...
scene Loading commit data...
sensors Loading commit data...
sim Loading commit data...
terrains Loading commit data...
utils Loading commit data...