-
Zoe McCarthy authored
# Description Fixes #2149 ## Type of change - New feature (non-breaking change which adds functionality) - This change requires a documentation update ## Screenshots Before:  After:  ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there ## Comments I couldn't find any tests for the docker container building, so I'm not sure where to add some. I'm happy to do so, and can add tests for some of the other docker building parameters if desired. I have tested locally for base and ros2 docker profiles with and without the new suffix parameter. The default setting is an empty string for the suffix, so it should be a non breaking change and most users will not notice it being there. I did not touch the cluster docker environment deployment since I do not have a cluster to test it with, so this new optional parameter should not be used in the cluster deployment case. I noticed that there was some redundant docker image building if the profile is `base`, so I added a check to only build base explicitly if the docker profile is not base, since the ros2 profile needs base built in order to build upon it, which is what I assume the explicit base building is there for. --------- Signed-off-by:
Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Co-authored-by:
Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| __init__.py | ||
| container_interface.py | ||
| state_file.py | ||
| x11_utils.py |