• Mayank Mittal's avatar
    Fixes environment closing and tests for task implementations (#231) · ab3f3a36
    Mayank Mittal authored
    # Description
    
    This MR fixes the test scripts inside the `omni.isaac.orbit_tasks`
    extension. The tests were previously crashing since they weren't updated
    to latest changes in the core framework.
    
    Additionally, the tests helped in realizing that the environment did not
    close properly, i.e. some managers do not get destroyed properly and
    still hold references to certain scene entities. The MR now explicitly
    calls all `del` operators over all the managers to delete them in the
    right-order.
    
    ## Type of change
    
    - Bug fix (non-breaking change which fixes an issue)
    
    ## Checklist
    
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./orbit.sh --format`
    - [ ] I have made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [x] I have added tests that prove my fix is effective or that my
    feature works
    - [x] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    
    ---------
    Signed-off-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
    ab3f3a36
Name
Last commit
Last update
.github Loading commit data...
.vscode Loading commit data...
docker Loading commit data...
docs Loading commit data...
source Loading commit data...
.dockerignore Loading commit data...
.flake8 Loading commit data...
.gitignore Loading commit data...
.pre-commit-config.yaml Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS.md Loading commit data...
LICENSE Loading commit data...
README.md Loading commit data...
VERSION Loading commit data...
orbit.sh Loading commit data...
pyproject.toml Loading commit data...