• Toni-SM's avatar
    Caches PhysX view's joint paths when processing fixed articulation tendons (#1347) · b3b45484
    Toni-SM authored
    # Description
    
    Cache PhysX view's DOF paths before looping when processing fixed
    articulation tendons to improve loading time.
    
    For the Shadow Hand task, calling `self.root_physx_view.dof_paths` when
    iterating over all joints to find tendons attached (in
    `Articulation._process_fixed_tendons` method) is an "expensive"
    operation. Timing can be reduced from 2.2 seconds to 300 milliseconds
    (13th Gen Intel® Core i9-13950HX × 32, RTX 5000) by calling
    `self.root_physx_view.dof_paths` once
    
    ## Screenshots
    
    Without any change
    ![Screenshot from 2024-10-28
    13-30-07](https://github.com/user-attachments/assets/0bd61f3d-3013-49fb-8540-c08236b974cf)
    
    After cache PhysX view's DOF paths before looping
    (`self.root_physx_view.dof_paths` called only once)
    ![Screenshot from 2024-10-28
    13-26-02](https://github.com/user-attachments/assets/6c2af86e-bd21-4b65-9c13-9610e6648e8d)
    
    
    ## Checklist
    
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./isaaclab.sh --format`
    - [ ] I have made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [x] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    b3b45484
Name
Last commit
Last update
.aws Loading commit data...
.github Loading commit data...
.vscode Loading commit data...
docker Loading commit data...
docs Loading commit data...
source Loading commit data...
tools Loading commit data...
.dockerignore Loading commit data...
.flake8 Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.pre-commit-config.yaml Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS.md Loading commit data...
LICENSE Loading commit data...
README.md Loading commit data...
VERSION Loading commit data...
isaaclab.bat Loading commit data...
isaaclab.sh Loading commit data...
pyproject.toml Loading commit data...