• lgulich's avatar
    Adds check that no articulation root API is applied on rigid bodies (#1358) · c2b32665
    lgulich authored
    # Description
    
    If a USD contains an articulation root but we load it with a
    `RigidObjectCfg` this would also load the articulation. This is
    confusing as a user only expects a rigid body.
    
    This PR adds a fix to ignore the articulation if a rigid body is
    spawned.
    
    <!--
    Thank you for your interest in sending a pull request. Please make sure
    to check the contribution guidelines.
    
    Link: https://isaac-sim.github.io/IsaacLab/source/refs/contributing.html
    -->
    
    Please include a summary of the change and which issue is fixed. Please
    also include relevant motivation and context.
    List any dependencies that are required for this change.
    
    Fixes # (issue)
    
    <!-- As a practice, it is recommended to open an issue to have
    discussions on the proposed pull request.
    This makes it easier for the community to keep track of what is being
    developed or added, and if a given feature
    is demanded by more than one party. -->
    
    ## Type of change
    
    <!-- As you go through the list, delete the ones that are not
    applicable. -->
    
    - Bug fix (non-breaking change which fixes an issue)
    
    ## Screenshots
    
    Please attach before and after screenshots of the change if applicable.
    
    <!--
    Example:
    
    | Before | After |
    | ------ | ----- |
    | _gif/png before_ | _gif/png after_ |
    
    To upload images to a PR -- simply drag and drop an image while in edit
    mode and it should upload the image directly. You can then paste that
    source into the above before/after sections.
    -->
    
    ## Checklist
    
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./isaaclab.sh --format`
    - [ ] I have made corresponding changes to the documentation
    - [ ] My changes generate no new warnings
    - [x] I have added tests that prove my fix is effective or that my
    feature works
    - [x] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    
    <!--
    As you go through the checklist above, you can mark something as done by
    putting an x character in it
    
    For example,
    - [x] I have done this task
    - [ ] I have not done this task
    -->
    
    ---------
    Signed-off-by: 's avatarlgulich <22480644+lgulich@users.noreply.github.com>
    Signed-off-by: 's avatarDavid Hoeller <dhoeller@nvidia.com>
    Signed-off-by: 's avatarKelly Guo <kellyg@nvidia.com>
    Co-authored-by: 's avatarDavid Hoeller <dhoeller@nvidia.com>
    Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
    c2b32665
Name
Last commit
Last update
..
CHANGELOG.rst Loading commit data...
README.md Loading commit data...