• James Tigue's avatar
    Changes to `quat_apply` and `quat_apply_inverse` for speed (#2129) · cdc66407
    James Tigue authored
    # Description
    
    As per findings in #1711, `quat_apply` was found to be faster that
    `quat_rotate`. This PR:
    - adds `quat_apply_inverse`
    - changes all instances of `quat_rotate` and `quat_rotate_inverse` to
    their apply counterparts.
    
    Fixes #1711
    
    ## Type of change
    
    - Bug fix (non-breaking change which fixes an issue)
    
    ## Screenshots
    
    | Per 1000 | cpu | cuda |
    |:----------|:-------:|:---------:|
    |**quat_apply:** |			**217.91 us** |	**47.07 us**|
    |einsum_quat_rotate: |		295.95 us |	127.62 us|
    |iter_quat_apply: |		679.10 us |	850.25 us|
    |iter_bmm_quat_rotate: |		829.62 us |	1.28 ms|
    |iter_einsum_quat_rotate: |	937.73 us |	1.46 ms|
    |**quat_apply_inverse:** |		**212.20 us** |	**48.43 us**|
    |einsum_quat_rotate_inverse: |	278.43 us |	114.25 us|
    |iter_quat_apply_inverse: |	681.85 us |	774.82 us|
    |iter_bmm_quat_rotate_inverse: |	863.27 us |	1.23 ms|
    |iter_einsum_quat_rotate_inverse: |	1.04 ms |	1.45 ms|
    
    ## Checklist
    
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./isaaclab.sh --format`
    - [x] I have made corresponding changes to the documentation
    - [ ] My changes generate no new warnings
    - [x] I have added tests that prove my fix is effective or that my
    feature works
    - [x] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    
    ---------
    Signed-off-by: 's avatarJames Tigue <166445701+jtigue-bdai@users.noreply.github.com>
    Signed-off-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
    Signed-off-by: 's avatarKelly Guo <kellyg@nvidia.com>
    Co-authored-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
    Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
    cdc66407
Name
Last commit
Last update
.aws Loading commit data...
.github Loading commit data...
.vscode Loading commit data...
apps Loading commit data...
docker Loading commit data...
docs Loading commit data...
scripts Loading commit data...
source Loading commit data...
tools Loading commit data...
.dockerignore Loading commit data...
.flake8 Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.pre-commit-config.yaml Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS.md Loading commit data...
LICENSE Loading commit data...
LICENSE-mimic Loading commit data...
README.md Loading commit data...
SECURITY.md Loading commit data...
VERSION Loading commit data...
environment.yml Loading commit data...
isaaclab.bat Loading commit data...
isaaclab.sh Loading commit data...
pyproject.toml Loading commit data...