• peterd-NV's avatar
    Adds matrix4d patch to support Pinocchio 2.7.0 (#352) · db85fabb
    peterd-NV authored
    <!--
    Thank you for your interest in sending a pull request. Please make sure
    to check the contribution guidelines.
    
    Link:
    https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html
    -->
    
    This change adds a patch in AppLauncher to override the Matrix4d
    constructor to convert it's arguments into a list of floats for
    compatibility with Pinocchio 2.7.0. This serves as a workaround until
    Isaac Sim is patched with the fix in a later release.
    
    The conda installation of Pinocchio 3.4.0 has been removed now that this
    solution enables support for Pinocchio 2.7.0.
    
    The corresponding documentation has also been updated now that this
    workaround is in place. This includes:
    1. Removing the note in Issac lab Mimic docs informing users of the
    error
    2. Restoring the Isaac Lab pip installation docs to original state (not
    using environment.yml to create the conda env)
    
    Fixes # (issue)
    
    Fixes error when running XR teleop with Pinocchio 2.7.0
    
    <!-- As you go through the list, delete the ones that are not
    applicable. -->
    
    - Bug fix (non-breaking change which fixes an issue)
    - This change requires a documentation update
    
    Please attach before and after screenshots of the change if applicable.
    
    <!--
    Example:
    
    | Before | After |
    | ------ | ----- |
    | _gif/png before_ | _gif/png after_ |
    
    To upload images to a PR -- simply drag and drop an image while in edit
    mode and it should upload the image directly. You can then paste that
    source into the above before/after sections.
    -->
    
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./isaaclab.sh --format`
    - [x] I have made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [x] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    
    <!--
    As you go through the checklist above, you can mark something as done by
    putting an x character in it
    
    For example,
    - [x] I have done this task
    - [ ] I have not done this task
    -->
    db85fabb
Name
Last commit
Last update
..
isaaclab Loading commit data...
isaaclab_assets Loading commit data...
isaaclab_mimic Loading commit data...
isaaclab_rl Loading commit data...
isaaclab_tasks Loading commit data...