• Louis LE LAY's avatar
    Fixes syntax for checking if pre-commit is installed in isaaclab.sh (#1422) · dbb3d4a7
    Louis LE LAY authored
    # Description
    
    When running `./isaaclab.sh --format` for another pull request, I got a
    `command not found` error for `pre-commit`. Looking into the script, I
    found a condition to check if `pre-commit` was installed, but the syntax
    was off.
    
    It was written like this:
    
    ```bash
    if [ ! command -v pre-commit &>/dev/null ]; then
    ```
    
    But it should be:
    
    ```bash
    if ! command -v pre-commit &>/dev/null; then
    ```
    
    I fixed it, and the script worked as expected, installing `pre-commit`
    when I ran it again.
    
    ## Type of change
    
    - Bug fix (non-breaking change which fixes an issue)
    
    ## Checklist
    
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./isaaclab.sh --format`
    - [x] I have made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [x] I have added tests that prove my fix is effective or that my
    feature works
    - [x] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    
    ---------
    Signed-off-by: 's avatarKelly Guo <kellyg@nvidia.com>
    Signed-off-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
    Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
    Co-authored-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
    dbb3d4a7
Name
Last commit
Last update
.aws Loading commit data...
.github Loading commit data...
.vscode Loading commit data...
docker Loading commit data...
docs Loading commit data...
source Loading commit data...
tools Loading commit data...
.dockerignore Loading commit data...
.flake8 Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.pre-commit-config.yaml Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS.md Loading commit data...
LICENSE Loading commit data...
README.md Loading commit data...
VERSION Loading commit data...
isaaclab.bat Loading commit data...
isaaclab.sh Loading commit data...
pyproject.toml Loading commit data...