• Octi Zhang's avatar
    Fixes error in Articulation where default_joint_stiffness and... · e8ea1850
    Octi Zhang authored
    Fixes error in Articulation where default_joint_stiffness and default_joint_damping is not correctly set if actuator is instance of ImplicitActuator (#1580)
    
    # Description
    
    Before the fix, the field, default_joint_stiffness, and
    default_joint_damping in omni.isaac.lab.assets.Articulation will be
    the default value configured Joint Drive property in usd file, and
    defining a new value with actuator config will not have effect
    if the actuator is type ImplicitActuator
    
    after the fix, all actuator types will be able to override
    default_joint_stiffness and default_joint_damping
    
    Fixes #1552 
    
    <!-- As a practice, it is recommended to open an issue to have
    discussions on the proposed pull request.
    This makes it easier for the community to keep track of what is being
    developed or added, and if a given feature
    is demanded by more than one party. -->
    
    ## Type of change
    
    <!-- As you go through the list, delete the ones that are not
    applicable. -->
    
    - Bug fix (non-breaking change which fixes an issue)
    
    <!--
    Example:
    
    | Before | After |
    | ------ | ----- |
    | _gif/png before_ | _gif/png after_ |
    
    To upload images to a PR -- simply drag and drop an image while in edit
    mode and it should upload the image directly. You can then paste that
    source into the above before/after sections.
    -->
    
    ## Checklist
    
    - [X] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./isaaclab.sh --format`
    - [ ] I have made corresponding changes to the documentation
    - [X] My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [X] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [X] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    
    <!--
    As you go through the checklist above, you can mark something as done by
    putting an x character in it
    
    For example,
    - [x] I have done this task
    - [ ] I have not done this task
    -->
    
    ---------
    Signed-off-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
    Co-authored-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
    Co-authored-by: 's avatarJames Tigue <166445701+jtigue-bdai@users.noreply.github.com>
    Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
    e8ea1850
Name
Last commit
Last update
.aws Loading commit data...
.github Loading commit data...
.vscode Loading commit data...
docker Loading commit data...
docs Loading commit data...
source Loading commit data...
tools Loading commit data...
.dockerignore Loading commit data...
.flake8 Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.pre-commit-config.yaml Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS.md Loading commit data...
LICENSE Loading commit data...
README.md Loading commit data...
VERSION Loading commit data...
isaaclab.bat Loading commit data...
isaaclab.sh Loading commit data...
pyproject.toml Loading commit data...