-
Miguel Alonso Jr. authored
# Description <!-- Thank you for your interest in sending a pull request. Please make sure to check the contribution guidelines. Link: https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html --> In the event manager, class based event terms are not registered properly due to a missing type() call. On [line 387 ](https://github.com/isaac-sim/IsaacLab/blob/7de6d6fef9424c95fc68dc767af67ffbe0da6832/source/isaaclab/isaaclab/managers/event_manager.py#L387)of event_manager.py, the check should be if isinstance(term_cfg.func, type(ManagerTermBase)): otherwise, isinstance always returns false (since ManagerTermBase is an abstract base class, the isintance method will check that term_cfg.func is derived from ABC, and not ManagerTermBase). Adding type(ManagerTermBase) resolves the issue. Fixes https://github.com/isaac-sim/IsaacLab/issues/2342 <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Screenshots Please attach before and after screenshots of the change if applicable. <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. --> ## Checklist - [X] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [X] My changes generate no new warnings - [X] I have added tests that prove my fix is effective or that my feature works - [X] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [X] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by:
Miguel Alonso Jr. <76960110+miguelalonsojr@users.noreply.github.com>
Signed-off-by:
Kelly Guo <kellyguo123@hotmail.com>
Co-authored-by:
Miguel Alonso Jr. <miguel.alonso@nfinite.app>
Co-authored-by:
Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Co-authored-by:
Kelly Guo <kellyguo123@hotmail.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| test_event_manager.py | ||
| test_observation_manager.py | ||
| test_recorder_manager.py | ||
| test_reward_manager.py |