• Mayank Mittal's avatar
    Fixes issue with asset deinitialization due to torch > 2.1 (#640) · ff6c9657
    Mayank Mittal authored
    # Description
    
    Ever since we upgraded the torch version from 2.0.1 (in Isaac Sim
    2023.1.1) to 2.2 (in Isaac Sim 4.0), we have seen some of the tests
    (such as `test_articulation.py`) fail due to improper deinitialization
    of the created class.
    
    This MR fixes this issue by creating a dummy tensor inside the
    `SimulationContext` in Isaac Lab. While this is a hack, it is effective
    and helps alleviate the problem. It is hard to figure out the root cause
    without really understanding what changed on the torch side.
    
    Fixes #639
    
    ## Type of change
    
    - Bug fix (non-breaking change which fixes an issue)
    - This change requires a documentation update
    
    ## Checklist
    
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./isaaclab.sh --format`
    - [ ] I have made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
    exists there
    ff6c9657
Name
Last commit
Last update
.github Loading commit data...
.vscode Loading commit data...
docker Loading commit data...
docs Loading commit data...
source Loading commit data...
tools Loading commit data...
.dockerignore Loading commit data...
.flake8 Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.pre-commit-config.yaml Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS.md Loading commit data...
LICENSE Loading commit data...
README.md Loading commit data...
VERSION Loading commit data...
isaaclab.bat Loading commit data...
isaaclab.sh Loading commit data...
pyproject.toml Loading commit data...