• Mayank Mittal's avatar
    Fixes the visualization markers to use the SpawnerCfg class (#162) · 9a61666c
    Mayank Mittal authored
    # Description
    
    * This MR fixes the `VisualizationMarkers` class to use the
    `SpawnerCfg`. This makes it consistent with how assets are spawned and
    allows more variations.
    * The markers also support instanceable meshes. This is done by
    disabling their instancing (as PointInstancer does not support
    pre-instanced assets) and removing any rigid body APIs from the asset.
    
    Fixes #144 
    
    ## Type of change
    
    - Bug fix (non-breaking change which fixes an issue)
    - New feature (non-breaking change which adds functionality)
    - Breaking change (fix or feature that would cause existing
    functionality to not work as expected)
    - This change requires a documentation update
    
    ## Screenshots
    
    https://github.com/isaac-orbit/orbit/assets/12863862/9d1b095b-99ee-4759-ba30-6175cc3b7d78
    
    ## Checklist
    
    - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
    `./orbit.sh --format`
    - [ ] I have made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [x] I have added tests that prove my fix is effective or that my
    feature works
    - [x] I have updated the changelog and the corresponding version in the
    extension's `config/extension.toml` file
    9a61666c
Name
Last commit
Last update
.github Loading commit data...
.vscode Loading commit data...
docker Loading commit data...
docs Loading commit data...
source Loading commit data...
.dockerignore Loading commit data...
.flake8 Loading commit data...
.gitignore Loading commit data...
.pre-commit-config.yaml Loading commit data...
LICENSE Loading commit data...
README.md Loading commit data...
VERSION Loading commit data...
orbit.sh Loading commit data...
pyproject.toml Loading commit data...