1. 26 Mar, 2025 1 commit
    • Harsh Patel's avatar
      Adds texture and scale randomization event terms (#2121) · 324bb8c3
      Harsh Patel authored
      # Description
      
      - Added back texture randomization event term
      - Carrying over texture randomization and scale randomization unit tests
      from previous PRs
      - Added additional replicate physics failure case test
      
      ## Type of change
      
      - New feature (non-breaking change which adds functionality)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [x] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      324bb8c3
  2. 25 Mar, 2025 1 commit
    • Pascal Roth's avatar
      Removes double definition of render settings (#2083) · 8f7f2b8e
      Pascal Roth authored
      # Description
      
      The definition of render settings in `SimulationCfg` is changed to None,
      which means that the default settings will be used from the experience
      files, and the double definition is removed.
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      Signed-off-by: 's avatarPascal Roth <57946385+pascal-roth@users.noreply.github.com>
      8f7f2b8e
  3. 23 Mar, 2025 2 commits
    • Louis LE LAY's avatar
      Fixes ground height in factory environment (#2071) · 9a2e9349
      Louis LE LAY authored
      # Description
      
      The table in the factory environment was initially positioned halfway
      into the ground due to an incorrect height translation. This PR corrects
      the initialization height to properly align the table with the ground,
      resolving the issue.
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Screenshots
      
      | Before | After |
      | ------ | ----- |
      | ![Screenshot from 2025-03-13
      08-02-24](https://github.com/user-attachments/assets/5aeb65c7-dd29-4ef1-a8fa-cb6a21cbe398)
      | ![Screenshot from 2025-03-13
      08-01-17](https://github.com/user-attachments/assets/7e932af3-f592-4da5-852f-9f8e21c54dae)
      |
      
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      9a2e9349
    • Mayank Mittal's avatar
      Adds more details about state in InteractiveScene (#2119) · 6f8ec452
      Mayank Mittal authored
      # Description
      
      It was hard to understand what the scene's state means unless you check
      the code. This MR adds more docstrings to make this simpler to
      understand.
      
      ## Type of change
      
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      6f8ec452
  4. 21 Mar, 2025 3 commits
    • Kelly Guo's avatar
      Fixes missing stage recorder extension for animation recorder (#2125) · f8cf6bad
      Kelly Guo authored
      # Description
      
      The default python base app file was missing the necessary extension
      dependencies to enable the animation recorder.
      "omni.kit.stagerecorder.bundle" is now added as a dependency, which
      should enable the recording functionality again.
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - Bug fix (non-breaking change which fixes an issue)
      
      
      ## Screenshots
      
      Please attach before and after screenshots of the change if applicable.
      
      <!--
      Example:
      
      | Before | After |
      | ------ | ----- |
      | _gif/png before_ | _gif/png after_ |
      
      To upload images to a PR -- simply drag and drop an image while in edit
      mode and it should upload the image directly. You can then paste that
      source into the above before/after sections.
      -->
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      f8cf6bad
    • Toni-SM's avatar
      Adds Gymnasium spaces showcase tasks (#2109) · c5fe1b5f
      Toni-SM authored
      # Description
      
      This PR add a set of Direct-workflow tasks that showcase the
      definition/use of the various Gymnasium observation and action spaces
      supported in Isaac Lab.
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - New feature (non-breaking change which adds functionality)
      - This change requires a documentation update
      
      ## Screenshots
      
      
      ![image](https://github.com/user-attachments/assets/36b526ac-0eb7-45fa-81fa-3d0a09c1c1c5)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      
      ---------
      Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
      c5fe1b5f
    • Wei Jinqi's avatar
      Fixes docstrings inconsistencies the code (#2112) · 1b03bf2f
      Wei Jinqi authored
      # Description
      
      <!--
      Thank you for your interest in sending a pull request. Please make sure
      to check the contribution guidelines.
      
      Link:
      https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html
      -->
      
      * Fixed the mismatch in :class:`JointPositionToLimitsActionCfg`
      docstring which was incorrectly referring to
      ``JointPositionWithinLimitsAction`` instead of
      ``JointPositionToLimitsAction``.
      * Fixed the issue of the :attr:`solver_velocity_iteration_count`
      docstring in :class:`ArticulationRootPropertiesCfg` being incorrect.
      * Fixed the mismatch between the default value of :attr:`use_cache` in
      :class:`TerrainGeneratorCfg` and its docstring. Currently, the default
      value is set to ``False``.
      
      Fixes #1330, #1377, #1827 
      
      <!-- As a practice, it is recommended to open an issue to have
      discussions on the proposed pull request.
      This makes it easier for the community to keep track of what is being
      developed or added, and if a given feature
      is demanded by more than one party. -->
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Screenshots
      
      Please attach before and after screenshots of the change if applicable.
      
      <!--
      Example:
      
      | Before | After |
      | ------ | ----- |
      | _gif/png before_ | _gif/png after_ |
      
      To upload images to a PR -- simply drag and drop an image while in edit
      mode and it should upload the image directly. You can then paste that
      source into the above before/after sections.
      -->
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      
      ---------
      Co-authored-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      1b03bf2f
  5. 20 Mar, 2025 1 commit
    • James Tigue's avatar
      Fixes default effort limit behavior for implicit actuators (#2098) · d7da02da
      James Tigue authored
      # Description
      
      This MR fixes the default behavior of implicit actuators if no effort limit is set. Previously, the check
      was using the class variable value instead of self which led to the wrong values getting propogated.
      
      Fixes #2054 
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      ---------
      Signed-off-by: 's avatarJames Tigue <166445701+jtigue-bdai@users.noreply.github.com>
      Co-authored-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      d7da02da
  6. 19 Mar, 2025 1 commit
    • Toni-SM's avatar
      Removes hamburger icon in template generator README (#2111) · 84e73359
      Toni-SM authored
      # Description
      
      This PR fixes https://github.com/isaac-sim/IsaacLab/issues/2094.
      Hamburger icon in the readme was causing encoding errors.
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      84e73359
  7. 14 Mar, 2025 2 commits
    • Kelly Guo's avatar
      Fixes manager tests requiring sim (#2075) · 91f53e2f
      Kelly Guo authored
      # Description
      
      A recent change requires the manager based env to have a sim object.
      This update fixes the manager tests to initialize a sim variable in the
      env class.
      
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - Bug fix (non-breaking change which fixes an issue)
      
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      91f53e2f
    • chengronglai's avatar
      Adds trial counter to saved image filenames in blueprint cfg (#2073) · f2d5b335
      chengronglai authored
      # Description
      
      Uses recorder_manager's successful episode count as trial number and
      adding it to saved image filenames.
      Track successful episodes across environments by adding trial counter to
      saved image filenames.
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - New feature (non-breaking change which adds functionality)
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [ ] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      f2d5b335
  8. 13 Mar, 2025 4 commits
    • Mayank Mittal's avatar
      Adds USD-level randomization mode to event manager (#2040) · 6b794ac2
      Mayank Mittal authored
      # Description
      
      Certain scene-level randomizations (such as randomizing the scale) must
      happen before the simulation starts playing. To this end, the MR adds a
      new event mode called "prestartup," which gets called right after the
      scene design is complete and before the simulation is played.
      
      Since the scene entities cannot be resolved before the simulation starts
      playing (as we currently rely on PhysX to provide us with the joint/body
      ordering), the MR adds a callback to resolve the scene entity
      configurations separately once the simulation plays.
      
      This MR replaces the prior implementation in #1165
      
      ## Type of change
      
      - New feature (non-breaking change which adds functionality)
      - This change requires a documentation update
      
      ## Screenshots
      
      If you execute:
      
      ```bash
      ./isaaclab.sh -p scripts/tutorials/03_envs/create_cube_base_env.py --num_envs 32
      ```
      
      Output:
      
      
      ![image](https://github.com/user-attachments/assets/a4b3a5e7-ff5c-4593-97ce-3b5af19bfde2)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [ ] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      ---------
      Signed-off-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      Co-authored-by: 's avatarJames Smith <142246516+jsmith-bdai@users.noreply.github.com>
      Co-authored-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      6b794ac2
    • Toni-SM's avatar
      Adds new external project / internal task template generator (#2039) · 80e3964d
      Toni-SM authored
      # Description
      
      This PR adds the implementation to generate Isaac Lab's external project
      or internal task.
      
      Just run `./isaaclab.sh --new` or `isaaclab.bat --new` (or `-n`) and let
      yourself go!
      
      ## Type of change
      
      - New feature (non-breaking change which adds functionality)
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      
      ---------
      Signed-off-by: 's avatarToni-SM <toni.semu@gmail.com>
      Signed-off-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
      80e3964d
    • Mayank Mittal's avatar
      Adds action clipping to rsl-rl wrapper (#2019) · f774425b
      Mayank Mittal authored
      # Description
      
      Currently, the actions from the policy are directly applied to the
      environment and also often fed back to the policy using the last action
      as observation.
      
      Doing this can lead to instability during training since applying a
      large action can introduce a negative feedback loop.
      More specifically, applying a very large action leads to a large
      last_action observations, which often results in a large error in the
      critic, which can lead to even larger actions being sampled in the
      future.
      
      This PR aims to fix this for RSL-RL library, by clipping the actions to
      (large) hard limits before applying them to the environment. This
      prohibits the actions from growing continuously and greatly improves
      training stability.
      
      Fixes #984, #1732, #1999
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      - New feature (non-breaking change which adds functionality)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      f774425b
    • Kelly Guo's avatar
      Fixes image link in documentation (#2066) · e6f63e21
      Kelly Guo authored
      # Description
      
      Fixes image link in documentation, the previous image was not added to
      the repo by accident
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Screenshots
      
      Please attach before and after screenshots of the change if applicable.
      
      <!--
      Example:
      
      | Before | After |
      | ------ | ----- |
      | _gif/png before_ | _gif/png after_ |
      
      To upload images to a PR -- simply drag and drop an image while in edit
      mode and it should upload the image directly. You can then paste that
      source into the above before/after sections.
      -->
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      e6f63e21
  9. 11 Mar, 2025 1 commit
    • chengronglai's avatar
      Adds blueprint environment for Franka stacking mimic (#1944) · 27cec08c
      chengronglai authored
      # Description
      
      This pull request refactors the core functionality of
      generate_dataset.py into separate helper modules. The goal is to make
      the associated Jupyter notebook leaner.
      
      * Move functions in generate_dataset to
      isaaclab_mimic/datagen/generation.py
      * Add utils.py for utility function for the notebook
      * Add dependency for ipywidgets
      
      ## Type of change
      
      - New feature (non-breaking change which adds functionality)
      
      ## Checklist
      
      - [ x] I have run the [`pre-commit` checks](https://pre-commit.com/)
      with `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [ ] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      
      ---------
      Signed-off-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      Co-authored-by: 's avatarJean-Francois-Lafleche <57650687+Jean-Francois-Lafleche@users.noreply.github.com>
      Co-authored-by: 's avatarPeter Du <peterd@nvidia.com>
      Co-authored-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
      27cec08c
  10. 10 Mar, 2025 1 commit
    • Kelly Guo's avatar
      Adds interactive demo script for H1 locomotion (#2041) · c8a7e47a
      Kelly Guo authored
      # Description
      
      This PR adds an interactive demo script that runs inference on a trained
      H1 rough terrain locomotion policy and allows selection of environments
      through clicking on a robot and controlling it with keyboard inputs.
      
      Additionally, a minor hyperparameter is updated in the SKRL training
      config for slightly better policy behavior.
      
      ## Type of change
      
      - New feature (non-breaking change which adds functionality)
      - This change requires a documentation update
      
      ## Screenshots
      
      
      ![h1_locomotion](https://github.com/user-attachments/assets/2de90aba-1195-4fea-b909-2cbbd67e716c)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      c8a7e47a
  11. 09 Mar, 2025 1 commit
    • Mayank Mittal's avatar
      Removes storage of meshes inside the TerrainImporter class (#1987) · 17fbff54
      Mayank Mittal authored
      # Description
      
      Sometimes users want to import a USD file which doesn't have any
      collider meshes. This MR allows having such USD files in the terrain
      importer for visualization purposes.
      
      Additionally, the MR removes the storage of warp and tri-mesh based
      meshes inside the class. These are stored into the USD and are read
      directly from there whenever needed. Their intended use-case for having
      them inside the terrain class is not needed.
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      - Breaking change
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [ ] My changes generate no new warnings
      - [x] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      ---------
      Signed-off-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      Co-authored-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      17fbff54
  12. 08 Mar, 2025 1 commit
    • Mayank Mittal's avatar
      Clarifies the default parameters in ArticulationData (#1875) · 46cbb5d6
      Mayank Mittal authored
      # Description
      
      There was a lot of code duplication happening inside the `Articulation`
      class. This MR takes a step towards untangling some of the confusion
      that gets caused by default and non-default data attributes inside the
      class.
      
      The MR includes the following changes:
      
      * Removes operations where we set the data to "torch.zeros" and in the
      next function assign them the value from PhysX. This made the code
      bulkier and complex for no reason.
      * Adds docstring clarifications to make it clear what is what. The
      default values are now whatever the user configures from their
      configuration of the articulation class.
      * Updates the `soft_joint_pos_limits` when the user writes the joint pos
      limits to the simulator.
      * Renames parameters for a consistent nomenclature:
      * ``joint_velocity_limits`` → ``joint_vel_limits`` (to match attribute
      ``joint_vel`` and ``joint_vel_limits``)
      * ``joint_limits`` → ``joint_pos_limits`` (to match attribute
      ``joint_pos`` and ``soft_joint_pos_limits``)
        * ``default_joint_limits`` → ``default_joint_pos_limits``
      * ``write_joint_limits_to_sim`` → ``write_joint_position_limit_to_sim``
        * ``joint_friction`` → ``joint_friction_coeff``
        * ``default_joint_friction`` → ``default_joint_friction_coeff``
      * ``write_joint_friction_to_sim`` →
      ``write_joint_friction_coefficient_to_sim``
        * ``fixed_tendon_limit`` → ``fixed_tendon_pos_limits``
        * ``default_fixed_tendon_limit`` → ``default_fixed_tendon_pos_limits``
        * ``set_fixed_tendon_limit`` → ``set_fixed_tendon_position_limit``
      
      Fixes #1583, #1904
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      - Breaking change (fix or feature that would cause existing
      functionality to not work as expected)
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      ---------
      Signed-off-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      Co-authored-by: 's avatarJames Tigue <166445701+jtigue-bdai@users.noreply.github.com>
      46cbb5d6
  13. 06 Mar, 2025 1 commit
    • Kelly Guo's avatar
      Bumps docker and pip version to 2.0.2 in the docs (#2018) · b5fa0eb0
      Kelly Guo authored
      # Description
      
      Updates versions in docs for 2.0.2.
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      
      ---------
      Co-authored-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      Co-authored-by: 's avatarMayank Mittal <mittalma@leggedrobotics.com>
      b5fa0eb0
  14. 05 Mar, 2025 10 commits
    • Kelly Guo's avatar
      Fixes vertical aperture check in RayCasterCamera test (#2020) · 769d0c5d
      Kelly Guo authored
      # Description
      
      The RayCasterCamera test checks that the vertical aperture should match
      the value specified in the config. However, the config's vertical
      aperture is not set. This PR updates the test to check against the
      default computed vertical aperture value instead.
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      769d0c5d
    • Pascal Roth's avatar
      Fixes path in the `launch.json` for RL training (#2021) · b8b79cfe
      Pascal Roth authored
      # Description
      
      Fix paths in `launch.json` to be adjusted to the new repo structure.
      
      Fixes #1976
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      b8b79cfe
    • Mayank Mittal's avatar
      Bumps IsaacLab version to 2.0.2 (#2016) · 0e4b38cd
      Mayank Mittal authored
      # Description
      
      The last MR before we make 2.0.2 release.
      
      ## Type of change
      
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      ---------
      Co-authored-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      0e4b38cd
    • Kelly Guo's avatar
      Adds workaround for semantic segmentation issue with tiled camera (#1947) · 868b4ffb
      Kelly Guo authored
      # Description
      
      In the Isaac Sim 4.5 release, ``TiledCamera`` produces incorrect
      semantic and instance segmentation outputs when using instanceable
      assets. With scene instancing enabled, only the first tile generates
      correct outputs while other tiles produces blank data. This change
      introduces a workaround for the issue by disabling instancing on the
      assets when semantic segmentation and instance segmentation data is
      required from ``TiledCamera``. This workaround introduces a small
      slowdown in performance, but it's not significant when running with
      smaller scenes, which is normally the case when using rendering.
      
      Fixes #1946 
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [x] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      
      ---------
      Signed-off-by: 's avatarKelly Guo <kellyg@nvidia.com>
      Signed-off-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      Co-authored-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      868b4ffb
    • Kelly Guo's avatar
      Updates docs for segmentation and 50 series GPUs issues (#1943) · 5fd22637
      Kelly Guo authored
      # Description
      
      This is a documentation only change that adds instructions for updating
      pytorch to the nightly build when running with 50 series GPUs to avoid
      CUDA issues. In addition, we added the v2.0.1 release notes and an extra
      note for the v2.0.0 release for a breaking change in the semantic and
      instance segmentation outputs when using tiled cameras.
      
      Fixes #1888
      
      ## Type of change
      
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      
      ---------
      Signed-off-by: 's avatarKelly Guo <kellyg@nvidia.com>
      5fd22637
    • Kelly Guo's avatar
      Sets default tensor device to CPU for Camera rot buffer (#2002) · 5235c278
      Kelly Guo authored
      # Description
      
      In the Camera class, we assumed that the default device for the torch
      tensor is CPU when we allocate the `rot` buffer during init. This isn't
      always the case if the user overwrites the torch device beforehand. This
      fix explicitly sets the tensor device to CPU on allocation.
      
      Fixes #1863 
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - Bug fix (non-breaking change which fixes an issue)
      
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      5235c278
    • Pascal Roth's avatar
      Reverts to old render settings in kit experience files (#1855) · 8b7fc5f8
      Pascal Roth authored
      # Description
      
      Reverts to old render settings.
      
      Fixes #1844 
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Screenshots
      
      Before:
      
      ![pre](https://github.com/user-attachments/assets/db3de96a-6b52-440f-9ed0-44185359e020)
      
      After:
      
      ![fdm_perceptive_demo_sim_with_traj_white_env1](https://github.com/user-attachments/assets/fac654f6-2a94-4417-b033-edc34c055ce3)
      
      
      ## Checklist
      
      - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [ ] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      ---------
      Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
      Co-authored-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      8b7fc5f8
    • Hongyu Li's avatar
      Fixes misalignment in motion vectors from TiledCamera (#2012) · efa4e28b
      Hongyu Li authored
      # Description
      
      I find the rendered motion_vectors (or optical flow) are not aligned
      with other modalities (such as RGB, depth, segmentation, etc.).
      This commit is a workaround to fix this misalignment issue.
      
      Fixes #2003
      
      <!-- As a practice, it is recommended to open an issue to have
      discussions on the proposed pull request.
      This makes it easier for the community to keep track of what is being
      developed or added, and if a given feature
      is demanded by more than one party. -->
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Screenshots
      
      Before:
      
      ![image](https://github.com/user-attachments/assets/acd2ba5c-a769-4759-b95b-1c31180355bb)
      
      After:
      
      ![image](https://github.com/user-attachments/assets/a7c82707-9862-4c06-a83f-3950cdf7ba14)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      ---------
      Signed-off-by: 's avatarHongyu Li <lihongyu0807@icloud.com>
      Signed-off-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      Signed-off-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      Co-authored-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      Co-authored-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      efa4e28b
    • Pascal Roth's avatar
      Fixes visualization error for RayCaster with `inf` values (#2008) · f2ad2244
      Pascal Roth authored
      # Description
      
      Fixes the rendering error when trying to have debug visualization
      enabled for a raycaster whose data points contain inf values.
      
      Observed error message
      ```
      2025-03-04 09:56:31 [39,045ms] [Error] [carb.graphics-vulkan.plugin] GPU crash is detected. Trying to write crash dump into: /home/pascal/isaacsim/v4.5/kit/logs/Kit/Isaac-Sim/4.5/kit_20250304_105552-0.nv-gpudmp
      2025-03-04 09:56:31 [39,045ms] [Error] [carb.graphics-vulkan.plugin] GPU crash dump is successfully written
      ```
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [ ] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      f2ad2244
    • Mayank Mittal's avatar
      Separates joint state setters inside Articulation class (#1751) · b0e1cbef
      Mayank Mittal authored
      # Description
      
      Previously in the Articulation class, there was a single method for
      setting joint state. However, it is desirable at times to only set joint
      position or velocity. For instance, for randomization events that pushes
      a joint by adding a random velocity to it.
      
      This MR separates the `write_joint_state_to_sim` into separate setters
      for joint positions and joint velocities. This goes inline with the
      method to set root pose, root velocity or the root state.
      
      ## Type of change
      
      - New feature (non-breaking change which adds functionality)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      ---------
      Signed-off-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
      b0e1cbef
  15. 04 Mar, 2025 1 commit
    • Mayank Mittal's avatar
      Fixes `activate_contact_sensors` when using spawner.MultiUsdFileCfg (#1990) · 4868e19c
      Mayank Mittal authored
      # Description
      
      This MR fixes the propagation of the `activate_contact_sensors`
      attribute to the `MultiAssetSpawnerCfg` class. Previously, this value is
      always set to `False`, leading to incorrect contact sensor settings for
      spawned assets.
      
      Fixes #1956 
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      4868e19c
  16. 03 Mar, 2025 4 commits
    • Mayank Mittal's avatar
      Moves information from FAQ to Isaac Lab Ecosystem (#1992) · 66844e9f
      Mayank Mittal authored
      # Description
      
      Since we have a more dedicated Isaac Lab Ecosystem page in the
      documentation, this MR removes the FAQ page and puts all its information
      to Isaac Lab Ecosystem.
      
      ## Type of change
      
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      ---------
      Signed-off-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      66844e9f
    • Johnson Sun's avatar
      Updates docs on Isaac Sim binary installation path and VSCode integration (#1970) · ea6ee91d
      Johnson Sun authored
      # Description
      
      - Update suggested Isaac Sim binary installation path
      Follows the paths (`~/isaacsim` on Linux, `C:\isaacsim` on Windows)
      suggested by Isaac Sim docs:
      
      https://docs.isaacsim.omniverse.nvidia.com/latest/installation/install_workstation.html
      - Update docs to emphasize that only Isaac Sim binary installation
      supports vscode integration
      - Fix minor typos
      
      Fixes: https://github.com/isaac-sim/IsaacLab/issues/1951
      ea6ee91d
    • Mayank Mittal's avatar
      Moves sensors to core-concepts in the documentation (#1989) · 8820bdff
      Mayank Mittal authored
      # Description
      
      This MR does the following:
      
      * Simplifies the names of sensor overview images by simply putting them
      into a directory
      * Moves sensors to core-concepts in the documentation
      * Fixes script headers in tutorials/demos to be consistent
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      8820bdff
    • Mayank Mittal's avatar
      Adds new extensions to `pyproject.toml` (#1988) · 38650265
      Mayank Mittal authored
      # Description
      
      Previously, the `pyproject.toml` was not including the newly added
      `isaaclab_rl` and `isaaclab_mimic` extensions. This affected the import
      ordering. This MR adds all of them under known extras.
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      38650265
  17. 02 Mar, 2025 5 commits
    • Mayank Mittal's avatar
      Adds event term function to randomize collider offsets (#1753) · 82f36138
      Mayank Mittal authored
      This MR adds an event term for randomizing the collider's rest and
      contact offsets.
      
      - New feature (non-breaking change which adds functionality)
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      82f36138
    • Kyle Morgenstein's avatar
      Supports setting the ground plane color using the terrain importer (#1791) · e787e9bf
      Kyle Morgenstein authored
      The default plane configuration supports setting the plane color, but
      this option is not currently exposed via the terrain importer. This PR
      adds a ``color'' field to the terrain importer that is only used for
      configuring a plane.
      
      - New feature (non-breaking change which adds functionality)
      
      <img width="912" alt="image"
      src="https://github.com/user-attachments/assets/4e509270-a953-49e8-88e7-b67bc1a92d2c"
      />
      
      <img width="909" alt="image"
      src="https://github.com/user-attachments/assets/0aa77530-befe-4c30-991d-e668561b9793"
      />
      
      Configuration:
      
      ```python
      terrain = TerrainImporterCfg(
                  prim_path="/World/ground",
                  terrain_type="plane",
                  terrain_generator=None,
                  max_init_terrain_level=None,
                  collision_group=-1,
                  physics_material=sim_utils.RigidBodyMaterialCfg(
                      friction_combine_mode="multiply",
                      restitution_combine_mode="multiply",
                      static_friction=1.0,
                      dynamic_friction=1.0,
                  ),
                  color=(1.0, 0.0, 0.0), # Red
                  debug_vis=False,
              )
      ```
      
      - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [X] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [X] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      ---------
      Signed-off-by: 's avatarKyle Morgenstein <34984693+KyleM73@users.noreply.github.com>
      Signed-off-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      Co-authored-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      e787e9bf
    • Mayank Mittal's avatar
      ae6c5f6c
    • Mayank Mittal's avatar
      Removes `disable_contact_processing` flag from SimulationContext (#1861) · cb5c7cab
      Mayank Mittal authored
      # Description
      
      The `disable_contact_processing` flag inside the SimulationContext
      causes confusion, as we were setting it to True in many environments,
      but it should be False since we want PhysX to report the contacts.
      
      This MR changes the default behavior now. It is always disabled (i.e. no
      contact reporting), until a contact sensor is created. It makes sure
      that the performance isn't hampered in situations where the user doesn't
      want to create any contact sensors.
      
      ## Type of Change
      
      - Bug fix (non-breaking change which fixes an issue)
      - Breaking change (fix or feature that would cause existing
      functionality to not work as expected)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [ ] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      cb5c7cab
    • Mayank Mittal's avatar
      Reverts the setting of joint velocity limits for implicit actuators (#1873) · 3d836ab1
      Mayank Mittal authored
      # Description
      
      The previous fix in #1654 was checking if `effort_limits_sim` is None
      instead of checking `cfg.effort_limits_sim` for explicit actuators. This
      did NOT work as effort limits sim is a tensor that gets assigned the
      value on initialization.
      
      The new fix now adds an implicit/explicit model attribute to the
      actuator model to ensure the right defaults are getting set. It moves
      all the implicit actuator warning code to its class to keep the
      articulation class cleaner.
      
      We also revert the behavior of setting velocity limits for implicit
      actuators to the state before #1509. Before that change, the parameter
      `velocity_limit` was set in the configurations but not getting passed
      through. The MR #1509 allowed these values to be set which caused many
      of the assets to not train anymore or behave differently between
      IsaacLab versions. We now revert this behavior with a warning. If users
      want to set the limits, they should use the `effort_limit_sim` and
      `velocity_limit_sim` quantities.
      
      Fixes #1837
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Screenshot
      
      The training of Allegro hand environment:
      * Green: The current main at 6a415df2
      * Black: This MR
      * Orange: Commenting out the setting of `write_joint_velocity_to_sim`
      which was introduced in #1509.
      
      
      ![image](https://github.com/user-attachments/assets/8ca1ded2-7d8f-4123-aea8-9082559885d7)
      
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [ ] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      ---------
      Signed-off-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      Co-authored-by: 's avatarJames Tigue <166445701+jtigue-bdai@users.noreply.github.com>
      3d836ab1