1. 06 Jul, 2024 4 commits
    • robotsfan's avatar
      Fixes quotes in the docker documentation (#648) · 97cf1f18
      robotsfan authored
      # Description
      
      There were minor quote issues in the docker container instructions. This
      MR fixes those.
      
      ## Type of change
      
      - This change requires a documentation update
      
      ## Checklist
      
      - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [ ] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      97cf1f18
    • Kelly Guo's avatar
      Optimizes interactive scene for homogeneous cloning (#636) · 190fa854
      Kelly Guo authored
      # Description
      
      Previously, we always assumed heterogeneous environment setup, which
      performed cloning on a per-actor basis during spawning of actors. In
      some direct workflow environments, a redundant cloning call was made at
      the end of environment setup to perform cloning on a global scope.
      
      With this change, we determine whether to perform cloning on a per-actor
      or global scope based on the `replicate_physics` parameter in
      `InteractiveSceneCfg`. When `replicate_physics=True`, homogeneous
      environment is assumed and cloning will only happen on a global scope.
      This reduces the time required for cloning for homogeneous setups. For
      heterogeneous environments, set `replicate_physics=False` and cloning
      will happen per-actor.
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      - New feature (non-breaking change which adds functionality)
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      190fa854
    • Mayank Mittal's avatar
      Fixes `isaaclab` scripts to deal with Isaac Sim pip installation (#631) · 07f082f5
      Mayank Mittal authored
      # Description
      
      Earlier the script hard-coded with path to Isaac Sim installation as the
      sym-linked directory "_isaac_sim". However, when doing PIP installation,
      this workflow doesn't hold. The MR modifies the scripts `isaaclab.sh`
      and `isaaclab.bat` to now check for PIP package installation and get
      paths from there if they exist.
      
      Fixes #516, #629
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [ ] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      ---------
      Signed-off-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
      07f082f5
    • David Hoeller's avatar
      Fixes the valid configs test in `lab_assets` extension (#647) · fccda6e0
      David Hoeller authored
      # Description
      
      Since the LiDAR configuration was added to the assets extension, the
      `test_valid_configs` test is failing.
      This MR removes sensors from configuration testing. The current set-up
      is not suitable for sensors, which require additional set-up (like
      creating a prim first or adding a mesh for the LiDAR).
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [x] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      fccda6e0
  2. 05 Jul, 2024 3 commits
    • Pascal Roth's avatar
      Adds lidar pattern for raycaster sensor (#616) · f3c7fe59
      Pascal Roth authored
      # Description
      
      Add a lidar pattern for the `RayCaster` sensor. The pattern is
      determined by number of channels, horizontal and vertical field of view
      and corresponding horizontal resolution. An example config for a
      Velodyne VLP 16 is provided.
      
      ## Type of change
      
      - New feature (non-breaking change which adds functionality)
      
      ## Screenshots
      
      ![Screenshot from 2024-07-02
      10-13-45](https://github.com/isaac-sim/IsaacLab/assets/57946385/31c87608-9d4d-4a11-9ad5-1ced954aa750)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      f3c7fe59
    • Mayank Mittal's avatar
      Removes the use of body view inside the asset classes (#643) · da34688b
      Mayank Mittal authored
      # Description
      
      The deprecation notice has been out for a while. The MR removes the body
      PhysX view from the rigid object and articulation classes. This is no
      longer needed as their respective root views expose all the data needed
      for them.
      
      This is a breaking change, and we lose compatibility with Isaac Sim
      2023.1.1.
      
      Fixes #237
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      - Breaking change (fix or feature that would cause existing
      functionality to not work as expected)
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      da34688b
    • Mayank Mittal's avatar
      Cleans up instructions for custom dependency installation (#621) · 5ffff16f
      Mayank Mittal authored
      # Description
      
      This MR mainly fixes the documentation to make instructions clearer. The
      script was unclear about where the workspace path needs to be and how it
      can be resolved. The MR makes sure these cases are dealt and reported
      correctly.
      
      ## Type of change
      
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      5ffff16f
  3. 04 Jul, 2024 6 commits
    • Mayank Mittal's avatar
      Fixes issue with asset deinitialization due to torch > 2.1 (#640) · ff6c9657
      Mayank Mittal authored
      # Description
      
      Ever since we upgraded the torch version from 2.0.1 (in Isaac Sim
      2023.1.1) to 2.2 (in Isaac Sim 4.0), we have seen some of the tests
      (such as `test_articulation.py`) fail due to improper deinitialization
      of the created class.
      
      This MR fixes this issue by creating a dummy tensor inside the
      `SimulationContext` in Isaac Lab. While this is a hack, it is effective
      and helps alleviate the problem. It is hard to figure out the root cause
      without really understanding what changed on the torch side.
      
      Fixes #639
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      ff6c9657
    • Shafeef Omar's avatar
      Adds support for PBS job scheduler based clusters (#605) · 08ebac7a
      Shafeef Omar authored
      # Description
      
      This pull request adds support for running IsaacLab on clusters that use
      PBS job schedulers (e.g. Franklin@IIT). Currently, it only supports
      SLURM. The job submission scripts have been modified to choose between
      SLURM or PBS job schedulers. The user can opt for the required job
      scheduler from `docker/cluster/.env.base` under cluster specific
      settings.
      
      Tested successfully on Franklin@IIT HPC.
      
      Fixes #599 
      
      ## Type of change
      
      - New feature (non-breaking change which adds functionality)
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      08ebac7a
    • Mayank Mittal's avatar
      Fixes VSCode settings to work with pip installation of Isaac Sim (#628) · 455a1748
      Mayank Mittal authored
      Earlier, the VSCode settings were only made for installation with
      binaries. This expected the path to be "_isaac_sim". As many users
      reported, this doesn't work if we have PIP installation of Isaac Sim.
      
      This MR fixes the above issue to ensure a smooth setup of vscode.
      
      Fixes #620, #629
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [ ] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      455a1748
    • Toni-SM's avatar
      Updates skrl integration to support training/evaluation using JAX (#592) · 4264e4f5
      Toni-SM authored
      # Description
      
      This PR updates the skrl integration to support training/evaluation
      using JAX ML framework
      
      ## Type of change
      
      - New feature (non-breaking change which adds functionality)
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      4264e4f5
    • Pascal Roth's avatar
      Adds empirical normalizer export when using rsl-rl workflow (#624) · 1c0a4abe
      Pascal Roth authored
      Adds the empirical normalizer in the ONNX model export for RSL-RL `play.py`
      script. Earlier, this was not being done, which would cause empirical
      normalization to not work in the ONNX model.
      
      - Bug fix (non-breaking change which fixes an issue)
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      1c0a4abe
    • Pascal Roth's avatar
      Fixes the double origin assignment in the quadrupeds example (#625) · 1a0afb60
      Pascal Roth authored
      # Description
      
      In the quadruped example, two robots are assigned the same origin. This
      PR fixes that.
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      1a0afb60
  4. 03 Jul, 2024 2 commits
  5. 02 Jul, 2024 2 commits
    • Mayank Mittal's avatar
      b9b28231
    • David Hoeller's avatar
      Fixes the rendering logic regression in environments (#614) · 59490f80
      David Hoeller authored
      # Description
      
      The previous rendering logic had a bug where a render call would also
      step physics `render_interval` number of times.
      
      This was a regression introduced in
      59493b89
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [x] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      59490f80
  6. 01 Jul, 2024 2 commits
    • Mayank Mittal's avatar
      Fixes the check for action-space inside Stable-Baselines3 wrapper (#610) · a02ed972
      Mayank Mittal authored
      # Description
      
      Earlier the wrapper was checking the action space boundedness through
      `is_bounded` function. However, that method returns a boolean instead of
      a string. This MR fixes this issue.
      
      Fixes #609
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      a02ed972
    • Mayank Mittal's avatar
      Removes duplicate enabling of faulthandler (#603) · 5c021834
      Mayank Mittal authored
      Sometimes the simulation app got stuck when trying to interrupt the
      process from the terminal. Removing the call to faulthandler resolved
      this issue (I think). In Isaac Sim 4.0, the fault handler is enabled
      inside the SimulationApp directly so we don't need to do it anymore.
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      5c021834
  7. 29 Jun, 2024 3 commits
    • Mayank Mittal's avatar
      691b9e81
    • Brayden Zhang's avatar
      Fixes open cabinet state machine run instructions in script (#600) · 019fc55a
      Brayden Zhang authored
      # Description
      
      Fixes documentation instructions error for open cabinet state machine.
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      019fc55a
    • Mayank Mittal's avatar
      Adds dark theme images for multi-GPU and actuators (#601) · 141e77c9
      Mayank Mittal authored
      # Description
      
      Previously, the images were rendered as "white" even in the dark theme
      of the documentation. This MR fixes the images and adds their
      counterpart for dark theme.
      
      ## Type of change
      
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      141e77c9
  8. 28 Jun, 2024 2 commits
    • Mayank Mittal's avatar
      Adds icons for OS to documentation tabs · d06b1f91
      Mayank Mittal authored
      d06b1f91
    • Mayank Mittal's avatar
      Reads gravity direction from simulation inside `RigidObjectData` (#582) · 915ebdd6
      Mayank Mittal authored
      # Description
      
      Previously, the gravity direction inside the `RigidObjectData` class was
      hard-coded as (0, 0, -1). However, this quantity may have a different
      direction in some simulation situations. This MR removes this hard
      coding and directly reads the value from the simulation view.
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      - New feature (non-breaking change which adds functionality)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [x] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      915ebdd6
  9. 27 Jun, 2024 5 commits
    • Mayank Mittal's avatar
      Changes documentation color to green theme (#585) · 1ba9db69
      Mayank Mittal authored
      # Description
      
      Changes documentation color to green theme.
      
      ## Type of change
      
      - This change requires a documentation update
      
      ## Screenshots
      
      | Light Theme | Dark Theme |
      | ------ | ----- |
      |
      ![image](https://github.com/isaac-sim/IsaacLab/assets/12863862/149af341-dd27-408f-aea8-1526bd92530c)
      |
      ![image](https://github.com/isaac-sim/IsaacLab/assets/12863862/39cef5e7-3917-4b77-9187-80b5c03cc2bc)
      |
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      1ba9db69
    • Mayank Mittal's avatar
      Fixes sphinx tabs to make them work in dark theme (#584) · aef99e45
      Mayank Mittal authored
      Earlier, we used the `sphinx-tabs` module, which didn't work well with
      the `sphinx-book-theme` of our documentation. This MR removes this
      dependency and uses `sphinx-design` instead for tabs. This natively
      supports the dark theme.
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      - This change requires a documentation update
      
      ## Screenshots
      
      
      https://github.com/isaac-sim/IsaacLab/assets/12863862/a56e1fa4-9b3c-4161-83bd-95b0e3b10334
      
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      aef99e45
    • Mayank Mittal's avatar
      Moves migration guides to their own section in the docs (#573) · ff5c1a94
      Mayank Mittal authored
      This MR moves the migration guide to their own section to make them more
      prominent. Additionally, it removes the migration information about
      Isaac Sim which is now outdated for the latest release.
      
      ## Type of change
      
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      ff5c1a94
    • Toni-SM's avatar
      Adds distributed multi-GPU learning support for skrl (#574) · 35345c63
      Toni-SM authored
      This PR updates `skrl` to version `>=1.2.0` and include the support for
      distributed multi-gpu learning in Isaac Lab docs,
      See [skrl-v1.2.0](https://github.com/Toni-SM/skrl/releases/tag/1.2.0)
      for more details
      
      ## Type of change
      
      - New feature (non-breaking change which adds functionality)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      35345c63
    • Mayank Mittal's avatar
      Fixes reference count in asset instances due to circular references (#580) · 1a7c86b9
      Mayank Mittal authored
      With the lazy buffer implementation in asset classes, we pass the
      physics sim-view to the data object. This increments the reference count
      of the sim-view instance and blocks the asset instance itself to be
      garbage collected properly.
      
      This MR takes steps to fix this issue.
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      1a7c86b9
  10. 26 Jun, 2024 4 commits
    • Mayank Mittal's avatar
      eb8d968d
    • Yuhui Fu's avatar
      Adds IsaacLab extensions to VSCode settings (#526) · ffec353e
      Yuhui Fu authored
      This MR adds the path of the isaac lab extensions to vscode
      `python.analysis.extraPaths` to execute intelligent prompt in vscode
      properly.
      
      Fixes #463
      
      - Bug fix (non-breaking change which fixes an issue)
      
      In  .vscode/tools/setup_vscode.py
      
      ![f9429980-bf0b-4e28-917b-10c0eccc92ce](https://github.com/isaac-sim/IsaacLab/assets/75050508/18cf4868-28be-4907-ae6e-be287ff946b1)
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      ffec353e
    • Mayank Mittal's avatar
      Adds support for underscore and hyphens in RL framework names (#566) · 3fccc994
      Mayank Mittal authored
      According to PIP, both`rl_games` and `rl-games` are valid PIP packages
      and are resolved similarly. This MR adds support for the different name
      conventions of PIP packages in the `setup.py` for the
      `omni.isaac.lab_tasks` extension.
      
      Fixes #547
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      3fccc994
    • Mayank Mittal's avatar
      Cleans up the buffer-related implementations (#562) · e28eeb74
      Mayank Mittal authored
      * Adds a lot of missing docstrings related to buffers and new actuator
      models
      * Nitpicks clean ups to make it simpler to read
      * Adds unit test for the circular buffer class
      
      ## Type of change
      
      - Breaking change (fix or feature that would cause existing
      functionality to not work as expected)
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [x] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      e28eeb74
  11. 25 Jun, 2024 4 commits
    • Mayank Mittal's avatar
      Adds an example showcasing different camera types (#565) · 0154535e
      Mayank Mittal authored
      # Description
      
      This MR fixes some of the docstrings related to the tile-rendering
      camera. Additionally, it adds a demo script showcasing the images
      obtained through the different camera implementations in IsaacLab.
      
      ## Type of change
      
      - New feature (non-breaking change which adds functionality)
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      0154535e
    • Mayank Mittal's avatar
      Cleans up the `omni.isaac.lab.envs` submodule (#548) · 3ef7e678
      Mayank Mittal authored
      # Description
      
      Earlier, it was unclear where the configuration classes and
      corresponding classes belonged inside the `omni.isaac.lab.envs` module.
      This MR reorganizes the module to ensure parity between the class and
      its respective configuration class. The MR also fixes docstrings with
      the hope of making things cleaner.
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      - Breaking change (fix or feature that would cause existing
      functionality to not work as expected)
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      3ef7e678
    • David Hoeller's avatar
      Fixes the rendering logic inside the environment classes (#515) · 59493b89
      David Hoeller authored
      Fixes #476
      
      The parameter substeps in the Simulation config had no influence on the
      rendering frequency.
      Additionally, app.update was not properly called when initializing the
      stage due to the render method overload. This led to problems when
      modifying the render interval.
      
      - Merged physics stepping and rendering inside the step method in the
      simulation config.
      - Renamed substeps to render_interval in the simulation config.
      - Updated all the tasks
      
      ## Type of change
      
      - Breaking change (fix or feature that would cause existing
      functionality to not work as expected)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [x] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      59493b89
    • David Hoeller's avatar
      Adds PIP dependencies to extension.toml file (#84) · 030d0bf5
      David Hoeller authored
      Fixes Isaac Lab when run in extension mode. 
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      030d0bf5
  12. 18 Jun, 2024 1 commit
    • Kelly Guo's avatar
      Fixes broken hyperlinks in the documentation (#524) · 9ab6b485
      Kelly Guo authored
      # Description
      
      This MR updates broken links in the documentation and code references.
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      9ab6b485
  13. 14 Jun, 2024 2 commits
    • Junghwan Ro's avatar
      Fixes root view to body view mapping in articulation (#497) · 3f96602e
      Junghwan Ro authored
      Fixes #475 
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [x] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have run all the tests with `./isaaclab.sh --test` and they pass
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      3f96602e
    • Kelly Guo's avatar
      Fixes CI docker tag for Isaac Sim (#496) · efcfeb70
      Kelly Guo authored
      Fixes Isaac Sim docker tag
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      efcfeb70