1. 14 May, 2025 2 commits
    • Kelly Guo's avatar
      Adds physics performance how-to guide (#2468) · e992592a
      Kelly Guo authored
      # Description
      
      Adds a new how-to guide on things to watch out for for better simulation
      performance. There have been a few recent threads on hitting performance
      issues due to usages of different collision geometries that can be
      watched out for and worked around. This new doc page highlights items to
      look out for to achieve better simulation performance.
      
      ## Type of change
      
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      e992592a
    • Kelly Guo's avatar
      Switches unittest to pytest for testing (#2459) · a4d3e0c4
      Kelly Guo authored
      # Description
      
      Switches our unit testing framework from unittest to pytest to enable
      better CI logging and improve developer experience when checking for
      test failures.
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      - New feature (non-breaking change which adds functionality)
      - Breaking change (fix or feature that would cause existing
      functionality to not work as expected)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [x] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      
      ---------
      Co-authored-by: 's avatarPascal Roth <roth.pascal@outlook.de>
      Co-authored-by: 's avatarPascal Roth <57946385+pascal-roth@users.noreply.github.com>
      a4d3e0c4
  2. 12 May, 2025 1 commit
  3. 11 May, 2025 2 commits
    • Harsh Patel's avatar
      Adds script to convert urdfs/meshes to instanceable USD in batches (#2248) · 0f58b3e6
      Harsh Patel authored
      # Description
      
      Adding a script that converts URDFs and Meshes to instanceable formatted
      usd in batch (recursively searching dir) so that users do not have to do
      it one at a time
      
      ## Type of change
      
      - New feature (non-breaking change which adds functionality)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      0f58b3e6
    • James Smith's avatar
      Adds serialization to observation and action managers (#2234) · 505679ff
      James Smith authored
      # Description
      This PR adds a serialize method to observation and action manager terms,
      so that they can be stored alongside a trained policy for later
      introspection.
      
      Fixes # (issue)
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - New feature (non-breaking change which adds functionality)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [ ] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      505679ff
  4. 09 May, 2025 5 commits
    • Zoe McCarthy's avatar
      Adds optional suffix parameter for docker name (#2172) · b1cd175f
      Zoe McCarthy authored
      # Description
      
      
      Fixes #2149 
      
      
      ## Type of change
      
      - New feature (non-breaking change which adds functionality)
      - This change requires a documentation update
      
      ## Screenshots
      
      
      Before:
      
      ![docker_name_suffix_before](https://github.com/user-attachments/assets/bc88b41f-69ec-434e-9f81-0189f7b90112)
      
      After:
      
      ![docker_name_suffix_after3](https://github.com/user-attachments/assets/4b2866a4-ef3d-4e05-8e27-d9ceae67831a)
      
      
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [x] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      ## Comments
      
      I couldn't find any tests for the docker container building, so I'm not
      sure where to add some. I'm happy to do so, and can add tests for some
      of the other docker building parameters if desired. I have tested
      locally for base and ros2 docker profiles with and without the new
      suffix parameter. The default setting is an empty string for the suffix,
      so it should be a non breaking change and most users will not notice it
      being there. I did not touch the cluster docker environment deployment
      since I do not have a cluster to test it with, so this new optional
      parameter should not be used in the cluster deployment case.
      
      I noticed that there was some redundant docker image building if the
      profile is `base`, so I added a check to only build base explicitly if
      the docker profile is not base, since the ros2 profile needs base built
      in order to build upon it, which is what I assume the explicit base
      building is there for.
      
      ---------
      Signed-off-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      Co-authored-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      b1cd175f
    • Harsh Patel's avatar
      Optimizes `yaw_quat` implementation (#2247) · 3b8da1d3
      Harsh Patel authored
      # Description
      
      Added optimizations to the yaw_quat function and added a function to
      test_math to make sure it works as intended.
      
      **BENCHMARKS:**
      
      Device: `cpu`
      
      ```
      Time for yaw_quat: <torch.utils.benchmark.utils.common.Measurement object at 0x7a342d1f8640>
      math_utils.yaw_quat(q_rand)  `511.79 us`
      1 measurement, 1000 runs , 1 thread
      
      Time for iter_yaw_quat: <torch.utils.benchmark.utils.common.Measurement object at 0x7a342d1f9720>
      iter_yaw_quat(q_rand)  `2.18 ms`
      1 measurement, 1000 runs , 1 thread
      
      Time for iter_old_yaw_quat: <torch.utils.benchmark.utils.common.Measurement object at 0x7a342d1f8640>
      iter_old_yaw_quat(q_rand)  `2.36 ms`
      1 measurement, 1000 runs , 1 thread
      ```
      
      ---
      
      Device: `cuda:0`
      
      ```
      Time for yaw_quat: <torch.utils.benchmark.utils.common.Measurement object at 0x7a342d1f8730>
      math_utils.yaw_quat(q_rand)  `246.16 us`
      1 measurement, 1000 runs , 1 thread
      
      Time for iter_yaw_quat: <torch.utils.benchmark.utils.common.Measurement object at 0x7a342d1f8100>
      iter_yaw_quat(q_rand)  `2.97 ms`
      1 measurement, 1000 runs , 1 thread
      
      Time for iter_old_yaw_quat: <torch.utils.benchmark.utils.common.Measurement object at 0x7a342d1f8730>
      iter_old_yaw_quat(q_rand)  `3.46 ms`
      1 measurement, 1000 runs , 1 thread
      ```
      
      ## Type of change
      
      - New feature (non-breaking change which adds functionality)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [x] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      3b8da1d3
    • Bikram Pandit's avatar
      Resets step reward buffer properly when weight is zero (#2392) · f1ba9c3a
      Bikram Pandit authored
      # Description
      
      This pull request fixes a bug where `_step_reward` could retain stale
      values when a reward term's weight was dynamically changed back to zero.
      Previously, when a reward term had zero weight, the computation skipped
      updating `_step_reward`, assuming that it would stay correct.
      However, if the weight was first changed from zero to nonzero and then
      back to zero during runtime (e.g., in curriculum settings), stale
      nonzero values could persist, causing incorrect reward visualizations or
      logging.
      
      This change explicitly sets `reward_manager._step_reward` to zero when a
      reward term has zero weight, ensuring correctness regardless of dynamic
      weight changes.
      
      Fixes #2391 
      
      No new dependencies are introduced by this change.
      
      ## Type of change
      
      - [x] Bug fix (non-breaking change which fixes an issue)
      - [ ] New feature (non-breaking change which adds functionality)
      - [ ] Breaking change (fix or feature that would cause existing
      functionality to not work as expected)
      - [ ] This change requires a documentation update
      
      ## Screenshots
      
      _Not applicable._
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      f1ba9c3a
    • Özhan Özen's avatar
      Fixes a minor typo in rsl_rl `rl_cfg` docstrings (#2445) · 1208f76b
      Özhan Özen authored
      # Description
      
      Fixes a minor typo in rsl_rl `rl_cfg` docstrings.
      
      **Before**
      ```
      normalize_advantage_per_mini_batch: bool = False
      """Whether to normalize the advantage per mini-batch. Default is False.
      
      If True, the advantage is normalized over the entire collected trajectories.
      Otherwise, the advantage is normalized over the mini-batches only.
      """
      ```
      **After**
      ```
      normalize_advantage_per_mini_batch: bool = False
      """Whether to normalize the advantage per mini-batch. Default is False.
      
      If True, the advantage is normalized over the mini-batches only.
      Otherwise, the advantage is normalized over the entire collected trajectories.
      """
      ```
      
      
      ## Type of change
      
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      1208f76b
    • Özhan Özen's avatar
      Fixes ray lazy metric reporting and hanging processes (#2346) · c9997d6a
      Özhan Özen authored
      # Description
      
      The step() function of ray/tuner.py has some issues preventing one from
      having an uninterrupted ray hyperparameter tuning session. Please refer
      to #2328 for details.
      
      Fixes #2328.
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [ ] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      c9997d6a
  5. 08 May, 2025 1 commit
  6. 05 May, 2025 1 commit
    • Kelly Guo's avatar
      Fixes training parameter for Shadow Hand (#2421) · 9be0de5f
      Kelly Guo authored
      # Description
      
      Fixes incorrect batch size for
      Isaac-Repose-Cube-Shadow-OpenAI-FF-Direct-v0
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - Bug fix (non-breaking change which fixes an issue)
      
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      9be0de5f
  7. 03 May, 2025 4 commits
    • James Tigue's avatar
      Adds joint effort observation (#2211) · 70a5ffcd
      James Tigue authored
      # Description
      
      <!--
      Thank you for your interest in sending a pull request. Please make sure
      to check the contribution guidelines.
      
      Link:
      https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html
      -->
      
      This PR adds in a joint_effort observation that exposes the
      `articulation.data.applied_effort`
      
      Fixes # (issue)
      
      <!-- As a practice, it is recommended to open an issue to have
      discussions on the proposed pull request.
      This makes it easier for the community to keep track of what is being
      developed or added, and if a given feature
      is demanded by more than one party. -->
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - New feature (non-breaking change which adds functionality)
      
      <!--
      Example:
      
      | Before | After |
      | ------ | ----- |
      | _gif/png before_ | _gif/png after_ |
      
      To upload images to a PR -- simply drag and drop an image while in edit
      mode and it should upload the image directly. You can then paste that
      source into the above before/after sections.
      -->
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      
      ---------
      Signed-off-by: 's avatarKelly Guo <kellyg@nvidia.com>
      Signed-off-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
      Co-authored-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      70a5ffcd
    • James Tigue's avatar
      Adds body_incoming_joint_wrench_b to ArticulationData field (#2128) · 1393f3b8
      James Tigue authored
      # Description
      
      <!--
      Thank you for your interest in sending a pull request. Please make sure
      to check the contribution guidelines.
      
      Link:
      https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html
      -->
      
      This PR exposes the physics tensor view of the joint reaction wrenches. 
      
      Fixes #[2127](https://github.com/isaac-sim/IsaacLab/issues/2127)
      [1566](https://github.com/isaac-sim/IsaacLab/issues/1566)
      
      <!-- As a practice, it is recommended to open an issue to have
      discussions on the proposed pull request.
      This makes it easier for the community to keep track of what is being
      developed or added, and if a given feature
      is demanded by more than one party. -->
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - New feature (non-breaking change which adds functionality)
      
      <!--
      Example:
      
      | Before | After |
      | ------ | ----- |
      | _gif/png before_ | _gif/png after_ |
      
      To upload images to a PR -- simply drag and drop an image while in edit
      mode and it should upload the image directly. You can then paste that
      source into the above before/after sections.
      -->
      
      ## Checklist
      
      - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [ ] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      
      ---------
      Signed-off-by: 's avatarJames Tigue <166445701+jtigue-bdai@users.noreply.github.com>
      Co-authored-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
      1393f3b8
    • yanziz-nvidia's avatar
      Uses --gpus instead of nvidia runtime for docker (#2411) · 8a913d09
      yanziz-nvidia authored
      # Description
      
      Use `--gpus all` instead of `nvidia: runtime` to prevent issues on
      unknown or invalid runtime name when running with docker or docker
      compose (python script).
      
      Fixes #2390 
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      - This change requires a documentation update
      
      ## Screenshots
      
      N/A
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      ---------
      Signed-off-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
      8a913d09
    • James Tigue's avatar
      Adds body_pose_w and body_projected_gravity_b observations (#2212) · fb4157e6
      James Tigue authored
      # Description
      
      <!--
      Thank you for your interest in sending a pull request. Please make sure
      to check the contribution guidelines.
      
      Link:
      https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html
      -->
      
      This PR add body_pose_w and body_projected_gravity_b observation methods
      
      Fixes # (issue)
      
      <!-- As a practice, it is recommended to open an issue to have
      discussions on the proposed pull request.
      This makes it easier for the community to keep track of what is being
      developed or added, and if a given feature
      is demanded by more than one party. -->
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - New feature (non-breaking change which adds functionality)
      
      <!--
      Example:
      
      | Before | After |
      | ------ | ----- |
      | _gif/png before_ | _gif/png after_ |
      
      To upload images to a PR -- simply drag and drop an image while in edit
      mode and it should upload the image directly. You can then paste that
      source into the above before/after sections.
      -->
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [ ] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      
      ---------
      Signed-off-by: 's avatarKelly Guo <kellyg@nvidia.com>
      Signed-off-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
      Co-authored-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      fb4157e6
  8. 30 Apr, 2025 1 commit
    • Kelly Guo's avatar
      Fixes failing environment and IK tests (#2372) · 5af5f388
      Kelly Guo authored
      # Description
      
      Fixes failing tests in test_environments and test_pink_ik.
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - Bug fix (non-breaking change which fixes an issue)
      
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      
      ---------
      Co-authored-by: 's avatarAshwin Varghese Kuruttukulam <ashwinvk@nvidia.com>
      5af5f388
  9. 26 Apr, 2025 1 commit
  10. 25 Apr, 2025 3 commits
    • Pascal Roth's avatar
      Fixes pose update in `Camera` and `TiledCamera` (#2316) · f3c54041
      Pascal Roth authored
      # Description
      
      Fixed `return_latest_camera_pose` option in `TiledCameraCfg` from not
      being used to the argument `update_latest_camera_pose` in `CameraCfg`
      with application in both `Camera` and `TiledCamera`.
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [ ] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      ---------
      Signed-off-by: 's avatarKelly Guo <kellyg@nvidia.com>
      Signed-off-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
      Co-authored-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      f3c54041
    • Miguel Alonso Jr.'s avatar
      Fixes check for manager term class inside event manager (#2357) · a52e0276
      Miguel Alonso Jr. authored
      # Description
      
      <!--
      Thank you for your interest in sending a pull request. Please make sure
      to check the contribution guidelines.
      
      Link:
      https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html
      -->
      
      In the event manager, class based event terms are not registered
      properly due to a missing type() call. On [line 387
      ](https://github.com/isaac-sim/IsaacLab/blob/7de6d6fef9424c95fc68dc767af67ffbe0da6832/source/isaaclab/isaaclab/managers/event_manager.py#L387)of
      event_manager.py, the check should be
      
                  if isinstance(term_cfg.func, type(ManagerTermBase)):
      otherwise, isinstance always returns false (since ManagerTermBase is an
      abstract base class, the isintance method will check that term_cfg.func
      is derived from ABC, and not ManagerTermBase). Adding
      type(ManagerTermBase) resolves the issue.
      
      Fixes https://github.com/isaac-sim/IsaacLab/issues/2342
      
      <!-- As a practice, it is recommended to open an issue to have
      discussions on the proposed pull request.
      This makes it easier for the community to keep track of what is being
      developed or added, and if a given feature
      is demanded by more than one party. -->
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Screenshots
      
      Please attach before and after screenshots of the change if applicable.
      
      <!--
      Example:
      
      | Before | After |
      | ------ | ----- |
      | _gif/png before_ | _gif/png after_ |
      
      To upload images to a PR -- simply drag and drop an image while in edit
      mode and it should upload the image directly. You can then paste that
      source into the above before/after sections.
      -->
      
      ## Checklist
      
      - [X] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [X] My changes generate no new warnings
      - [X] I have added tests that prove my fix is effective or that my
      feature works
      - [X] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [X] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      
      ---------
      Signed-off-by: 's avatarMiguel Alonso Jr. <76960110+miguelalonsojr@users.noreply.github.com>
      Signed-off-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      Co-authored-by: 's avatarMiguel Alonso Jr. <miguel.alonso@nfinite.app>
      Co-authored-by: 's avatarMayank Mittal <12863862+Mayankm96@users.noreply.github.com>
      Co-authored-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      a52e0276
    • Kelly Guo's avatar
      Adds v2.1.0 release notes (#2359) · 8d72e872
      Kelly Guo authored
      # Description
      
      Adds release notes to the docs for the 2.1.0 release.
      
      ## Type of change
      
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      8d72e872
  11. 23 Apr, 2025 2 commits
    • Kelly Guo's avatar
      Adds licenses folder to docker container (#387) · 21f71363
      Kelly Guo authored
      # Description
      
      Adds licenses folder to docker container. previously it was included as
      part of .dockerignore and not copied into the container.
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      21f71363
    • Kelly Guo's avatar
      Adds additional license files for dependencies (#386) · e750e66b
      Kelly Guo authored
      # Description
      
      Adds license files for additional 3rd party OSS dependencies added to
      Isaac Lab.
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      e750e66b
  12. 16 Apr, 2025 2 commits
    • Kelly Guo's avatar
      Removes quadprog from docker container (#384) · b6bd3e6a
      Kelly Guo authored
      # Description
      
      Removes quadprog from docker container due to licensing issues. This is
      a workaround since it gets pulled from pin-pink, but we do not need to
      use the package for anything.
      
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - Bug fix (non-breaking change which fixes an issue)
      
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      b6bd3e6a
    • Ashwin Varghese Kuruttukulam's avatar
      Removes direct usage of qpsolvers and changes solver to osqp (#383) · 128436f8
      Ashwin Varghese Kuruttukulam authored
      # Description
      
      Remove qpsolvers direct usage and replace quadprog solver with osqp.
      
      ## Type of change
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      
      ---------
      Co-authored-by: 's avatarPeter Du <peterd@nvidia.com>
      128436f8
  13. 14 Apr, 2025 2 commits
    • Kelly Guo's avatar
      Moves quickstart page before installation (#382) · f9099959
      Kelly Guo authored
      # Description
      
      Moves the quick start guide to before installation pages in the docs.
      
      ## Type of change
      
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      f9099959
    • Kelly Guo's avatar
      Updates render mode presets (#381) · bc1d2a57
      Kelly Guo authored
      # Description
      
      Updates render mode presets to:
      
      - better align balanced modes with current settings
      - incorporate feedback from rendering team regarding use of
      denoisingTechnique should always be 0 and avoid setting
      upperLowerStrategy when RR is enabled
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - Bug fix (non-breaking change which fixes an issue)
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      bc1d2a57
  14. 12 Apr, 2025 13 commits
    • Kelly Guo's avatar
      Bumps version to 2.1.0 (#378) · dcd877f0
      Kelly Guo authored
      # Description
      
      Bumps version to 2.1.0
      
      ## Type of change
      
      - This change requires a documentation update
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      dcd877f0
    • Kelly Guo's avatar
      Updates environments requiring enable_camera in environment list (#377) · 2da5d917
      Kelly Guo authored
      # Description
      
      Documentation only update to indicate which environments require running
      with the `--enable_cameras` flag.
      
      <!-- As a practice, it is recommended to open an issue to have
      discussions on the proposed pull request.
      This makes it easier for the community to keep track of what is being
      developed or added, and if a given feature
      is demanded by more than one party. -->
      
      ## Type of change
      
      - This change requires a documentation update
      
      ## Screenshots
      
      Please attach before and after screenshots of the change if applicable.
      
      <!--
      Example:
      
      | Before | After |
      | ------ | ----- |
      | _gif/png before_ | _gif/png after_ |
      
      To upload images to a PR -- simply drag and drop an image while in edit
      mode and it should upload the image directly. You can then paste that
      source into the above before/after sections.
      -->
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      2da5d917
    • cosmith-nvidia's avatar
      Updates CloudXR doc with stronger requirements and bimanual teleop gif (#372) · fcbe1fd8
      cosmith-nvidia authored
      # Description
      
      Updating CloudXR doc with stronger requirements and bimanual teleop gif
      
      ## Type of change
      
      - Documentation
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      fcbe1fd8
    • Kelly Guo's avatar
      Updates environment table with enable_cameras (#374) · 8320a97c
      Kelly Guo authored
      # Description
      
      Updates environment table with enable_cameras to specify explicitly
      which environments require running with `--enable_cameras`.
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - This change requires a documentation update
      
      ## Screenshots
      
      Please attach before and after screenshots of the change if applicable.
      
      <!--
      Example:
      
      | Before | After |
      | ------ | ----- |
      | _gif/png before_ | _gif/png after_ |
      
      To upload images to a PR -- simply drag and drop an image while in edit
      mode and it should upload the image directly. You can then paste that
      source into the above before/after sections.
      -->
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      8320a97c
    • peterd-NV's avatar
      Divides GR1 collect/annotate steps into subsections in Mimic docs (#373) · fa93991a
      peterd-NV authored
      # Description
      
      <!--
      Thank you for your interest in sending a pull request. Please make sure
      to check the contribution guidelines.
      
      Link:
      https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html
      -->
      
      Update the Mimic doc by dividing the GR1 collection/annotation steps
      into subsections to clarify that they are different steps.
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - Documentation update
      
      ## Screenshots
      
      Please attach before and after screenshots of the change if applicable.
      
      <!--
      Example:
      
      | Before | After |
      | ------ | ----- |
      | _gif/png before_ | _gif/png after_ |
      
      To upload images to a PR -- simply drag and drop an image while in edit
      mode and it should upload the image directly. You can then paste that
      source into the above before/after sections.
      -->
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      fa93991a
    • peterd-NV's avatar
      Adds clarification diagrams to Mimic docs (#371) · bb3f19a9
      peterd-NV authored
      # Description
      
      <!--
      Thank you for your interest in sending a pull request. Please make sure
      to check the contribution guidelines.
      
      Link:
      https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html
      -->
      
      1. Updates the Mimic docs and adds a diagram to show correct annotation
      for the GR1 pick place task.
      2. Move the pick place task gif so that users can reference it when
      collecting demos.
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - Documentation update
      
      ## Screenshots
      
      Please attach before and after screenshots of the change if applicable.
      
      <!--
      Example:
      
      | Before | After |
      | ------ | ----- |
      | _gif/png before_ | _gif/png after_ |
      
      To upload images to a PR -- simply drag and drop an image while in edit
      mode and it should upload the image directly. You can then paste that
      source into the above before/after sections.
      -->
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      
      ---------
      Signed-off-by: 's avatarKelly Guo <kellyguo123@hotmail.com>
      Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
      bb3f19a9
    • Michael Gussert's avatar
      Adds a quick start guide for quick installation and introduction (#370) · bd219022
      Michael Gussert authored
      This PR adds a quickstart guide and various references to the setup
      instructions for Isaac Lab
      
      ## Checklist
      
      - [X] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [X] I have made corresponding changes to the documentation
      - [X] My changes generate no new warnings
      - [X] I have added tests that prove my fix is effective or that my
      feature works
      - [X] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [X] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      ---------
      Signed-off-by: 's avatarMichael Gussert <michael@gussert.com>
      Co-authored-by: 's avatarKelly Guo <kellyg@nvidia.com>
      bd219022
    • Kelly Guo's avatar
      Fixes docstring for semantic_segmentation_mapping (#367) · 8af1fadd
      Kelly Guo authored
      # Description
      
      Fixes docstring description of dictionary example for CameraCfg
      semantic_segmentation_mapping to properly format dictionary in
      documentation.
      
      Fixes # (issue)
      
      <!-- As a practice, it is recommended to open an issue to have
      discussions on the proposed pull request.
      This makes it easier for the community to keep track of what is being
      developed or added, and if a given feature
      is demanded by more than one party. -->
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - This change requires a documentation update
      
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      8af1fadd
    • rwiltz's avatar
      Fixes the wrist rotation option in se3_abs_retargeter (#369) · 9f137473
      rwiltz authored
      # Description
      
      Fixes the wrist rotation option in se3_abs_retargeter 
      
      <!-- As a practice, it is recommended to open an issue to have
      discussions on the proposed pull request.
      This makes it easier for the community to keep track of what is being
      developed or added, and if a given feature
      is demanded by more than one party. -->
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Screenshots
      
      Please attach before and after screenshots of the change if applicable.
      
      <!--
      Example:
      
      | Before | After |
      | ------ | ----- |
      | _gif/png before_ | _gif/png after_ |
      
      To upload images to a PR -- simply drag and drop an image while in edit
      mode and it should upload the image directly. You can then paste that
      source into the above before/after sections.
      -->
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [x] I have added tests that prove my fix is effective or that my
      feature works
      - [x] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      9f137473
    • Kelly Guo's avatar
      Updates docker installation with X11 forwarding (#365) · bf80ade3
      Kelly Guo authored
      # Description
      
      Although the current docker command still works for headless rendering,
      it sometimes generates an error message from carbonite. This change adds
      an option to enable X11 forwarding when using the prebuilt docker image,
      which fixes the error.
      
      ## Type of change
      
      - This change requires a documentation update
      
      ## Screenshots
      
      Please attach before and after screenshots of the change if applicable.
      
      <!--
      Example:
      
      | Before | After |
      | ------ | ----- |
      | _gif/png before_ | _gif/png after_ |
      
      To upload images to a PR -- simply drag and drop an image while in edit
      mode and it should upload the image directly. You can then paste that
      source into the above before/after sections.
      -->
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      bf80ade3
    • Kelly Guo's avatar
      Saves checkpoint at first iteration of feature extractor (#363) · 5d75f825
      Kelly Guo authored
      # Description
      
      Saves a checkpoint file on the first iteration of the feature extractor
      so that a checkpoint is available if inferencing early on in the
      training process. Previously, we had to wait until 50k steps for the
      checkpoint to be saved.
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - Bug fix (non-breaking change which fixes an issue)
      
      
      ## Screenshots
      
      Please attach before and after screenshots of the change if applicable.
      
      <!--
      Example:
      
      | Before | After |
      | ------ | ----- |
      | _gif/png before_ | _gif/png after_ |
      
      To upload images to a PR -- simply drag and drop an image while in edit
      mode and it should upload the image directly. You can then paste that
      source into the above before/after sections.
      -->
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [x] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      5d75f825
    • matthewtrepte's avatar
      Updates Rendering Mode guide in documentation (#361) · a62181b2
      matthewtrepte authored
      # Description
      
      <!--
      Thank you for your interest in sending a pull request. Please make sure
      to check the contribution guidelines.
      
      Link:
      https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html
      -->
      
      Added in a detail for selecting the Rendering Mode from the CLI
      argument.
      
      <!-- As a practice, it is recommended to open an issue to have
      discussions on the proposed pull request.
      This makes it easier for the community to keep track of what is being
      developed or added, and if a given feature
      is demanded by more than one party. -->
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - Bug fix (non-breaking change which fixes an issue)
      
      ## Screenshots
      
      Please attach before and after screenshots of the change if applicable.
      
      <!--
      Example:
      
      | Before | After |
      | ------ | ----- |
      | _gif/png before_ | _gif/png after_ |
      
      To upload images to a PR -- simply drag and drop an image while in edit
      mode and it should upload the image directly. You can then paste that
      source into the above before/after sections.
      -->
      
      ## Checklist
      
      - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [ ] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      a62181b2
    • peterd-NV's avatar
      Fixes idle action in replay script for GR1 Pick-Place env (#360) · 01dcde53
      peterd-NV authored
      # Description
      
      <!--
      Thank you for your interest in sending a pull request. Please make sure
      to check the contribution guidelines.
      
      Link:
      https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html
      -->
      
      Adds an "idle_action" parameter to the GR1 pick-place env. The
      replay_demo script is also updated to check if envs have an idle action
      pre-defined in its config and uses it if present. If not present, the
      replay script will continue to use a zero tensor for idle actions.
      
      This fixes errors during demo replay if an env doesn't support a zero
      action tensor.
      
      ## Type of change
      
      <!-- As you go through the list, delete the ones that are not
      applicable. -->
      
      - Bug fix (non-breaking change which fixes an issue)
      
      
      ## Checklist
      
      - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
      `./isaaclab.sh --format`
      - [ ] I have made corresponding changes to the documentation
      - [x] My changes generate no new warnings
      - [ ] I have added tests that prove my fix is effective or that my
      feature works
      - [ ] I have updated the changelog and the corresponding version in the
      extension's `config/extension.toml` file
      - [x] I have added my name to the `CONTRIBUTORS.md` or my name already
      exists there
      
      <!--
      As you go through the checklist above, you can mark something as done by
      putting an x character in it
      
      For example,
      - [x] I have done this task
      - [ ] I have not done this task
      -->
      01dcde53